Skip to content

fix tests that accidentaly got broken #3543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GuySten merged 1 commit into from
Aug 21, 2025
Merged

fix tests that accidentaly got broken #3543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix tests that accidentaly got broken
  • Loading branch information
@GuySten
GuySten committed Aug 21, 2025
commit 579db752dcaa186ffe2351be6eab7ea8f93e820f
7 changes: 4 additions & 3 deletions tests/unit_tests/test_material.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,11 +738,12 @@ def test_material_deplete():
chain_file=chain,
)

for material in depleted_material:
for i_step, material in enumerate(depleted_material):
assert isinstance(material, openmc.Material)
assert len(material.get_nuclides()) > len(pristine_material.get_nuclides())
if i_step > 0:
assert len(material.get_nuclides()) > len(pristine_material.get_nuclides())

Co58_mat_1_step_0 = depleted_material[0].get_nuclide_atom_densities("Co58")["Co58"]
Co58_mat_1_step_0 = depleted_material[0].get_nuclide_atom_densities("Co58").get("Co58", 0.0)
Co58_mat_1_step_1 = depleted_material[1].get_nuclide_atom_densities("Co58")["Co58"]
Co58_mat_1_step_2 = depleted_material[2].get_nuclide_atom_densities("Co58")["Co58"]

Expand Down
9 changes: 5 additions & 4 deletions tests/unit_tests/test_materials.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,14 @@ def test_materials_deplete():

assert list(depleted_material.keys()) == [pristine_material_1.id, pristine_material_2.id]
for mat_id, materials in depleted_material.items():
for material in materials:
for i_step, material in enumerate(materials):
assert isinstance(material, openmc.Material)
assert len(material.get_nuclides()) > 1
if i_step > 0:
assert len(material.get_nuclides()) > 1
assert mat_id == material.id

mats = depleted_material[pristine_material_1.id]
Co58_mat_1_step_0 = mats[0].get_nuclide_atom_densities("Co58")["Co58"]
Co58_mat_1_step_0 = mats[0].get_nuclide_atom_densities("Co58").get("Co58", 0.0)
Co58_mat_1_step_1 = mats[1].get_nuclide_atom_densities("Co58")["Co58"]
Co58_mat_1_step_2 = mats[2].get_nuclide_atom_densities("Co58")["Co58"]

Expand All @@ -53,7 +54,7 @@ def test_materials_deplete():
# It then decays in the second cooling step (flux = 0)
assert Co58_mat_1_step_1 > 0.0 and Co58_mat_1_step_1 > Co58_mat_1_step_2

Ni59_mat_1_step_0 = mats[0].get_nuclide_atom_densities("Ni59")["Ni59"]
Ni59_mat_1_step_0 = mats[0].get_nuclide_atom_densities("Ni59").get("Ni59", 0.0)
Ni59_mat_1_step_1 = mats[1].get_nuclide_atom_densities("Ni59")["Ni59"]
Ni59_mat_1_step_2 = mats[2].get_nuclide_atom_densities("Ni59")["Ni59"]

Expand Down