Skip to content

fix tests that accidentaly got broken - #3543

Merged
GuySten merged 1 commit into
openmc-dev:developfrom
GuySten:fix-tests
Aug 21, 2025
Merged

GuySten merged 1 commit into
openmc-dev:developfrom
GuySten:fix-tests

Conversation

@GuySten

@GuySten GuySten commented Aug 21, 2025

Copy link
Copy Markdown
Contributor

Description

PR #3448, accidentally broke some tests. This PR fix them.

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@GuySten
GuySten enabled auto-merge (squash) August 21, 2025 15:50

@paulromano paulromano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! How did it get merged in the first place if it broke tests though?

@GuySten

GuySten commented Aug 21, 2025

Copy link
Copy Markdown
Contributor Author

I think it broke tests that were added later.

@paulromano

Copy link
Copy Markdown
Contributor

Ah ok, that makes sense. I guess that PR was a bit old.

@GuySten
GuySten merged commit 5e3249f into openmc-dev:develop Aug 21, 2025
@GuySten
GuySten deleted the fix-tests branch August 21, 2025 21:49
apingegno pushed a commit to apingegno/openmc that referenced this pull request May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants