Repository navigation
cy mesh origin from start of z_grid and _r_grid - #2680
Merged
pshriwise merged 3 commits intoSep 4, 2023
Merged
Conversation
pshriwise
requested changes
Sep 4, 2023
pshriwise
left a comment
pshriwise
left a comment
Contributor
There was a problem hiding this comment.
Looks good @shimwell! Sorry for the ask on out-of-scope lines, but I noticed that the comment on above the declaration of cached_bb is DAGMC-specific. It's beneficial to pre-compute the bounding box in either CSG or DAGMC geometry. Would you mind updating that to something more general?
pshriwise
approved these changes
Sep 4, 2023
stchaker
pushed a commit
to stchaker/openmc
that referenced
this pull request
Oct 25, 2023
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to fix the cylindrical mesh origin again 😊
PR #2676 put the origin at the center of the mesh when it should have been at the start of the mesh.
Totally my fault, hopefully this fix is actually right this time. I added more tests to check off axis behavior
Fixes # (issue)
Checklist