Repository navigation
Conversation
paulromano
approved these changes
Sep 1, 2023
paulromano
left a comment
paulromano
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix @shimwell! I realized that the documentation for z_grid was confusing in that it didn't mention that it is relative to the origin, so I just added a commit here on your branch updating that. Hope you don't mind! 😄
Member
Author
|
As this is a small PR and it has been approved a few days ago I think this one can be merged |
3 tasks done
stchaker
pushed a commit
to stchaker/openmc
that referenced
this pull request
Oct 25, 2023
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While making cylindrical meshes from a domain I noticed the mesh was not fitting the geometry correctly in the Z direction. After digging into the code I noticed that the origin was not set and therefore defaulting to 0,0,0. My geometry starts on the zplane=0 and goes upwards. Anyway this PR now sets the origin to the center of the bounding box.
Fixes # (issue)
Checklist