Skip to content

Adding type hints to meshes #2601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulromano merged 6 commits into from
Jul 21, 2023
Merged

Adding type hints to meshes #2601

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a569f06
added type hints for meshes
shimwell Jul 17, 2023
83e93d3
postponed evaluation for domains
shimwell Jul 17, 2023
971d36b
added space around =
shimwell Jul 17, 2023
5fbc3bf
str and Path instead of Pathlike
shimwell Jul 18, 2023
2195418
Apply suggestions from code review by @paulromano
shimwell Jul 21, 2023
2d4464b
using typing.Optional instead of Optional
shimwell Jul 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
str and Path instead of Pathlike
  • Loading branch information
@shimwell
shimwell authored Jul 18, 2023
commit 5fbc3bf681cd13835df681a8ca719474feb1463a
2 changes: 1 addition & 1 deletion openmc/mesh.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1784,7 +1784,7 @@ def filename(self):

@filename.setter
def filename(self, filename):
cv.check_type('Unstructured Mesh filename', filename, PathLike)
cv.check_type('Unstructured Mesh filename', filename, (str, Path))
self._filename = filename

@property
Expand Down