Repository navigation
Adding type hints to meshes - #2601
Merged
Merged
Conversation
shimwell
commented
Jul 17, 2023
Member
Author
|
CI is failing with |
shimwell
commented
Jul 18, 2023
paulromano
requested changes
Jul 21, 2023
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
shimwell
commented
Jul 21, 2023
paulromano
enabled auto-merge (squash)
July 21, 2023 16:07
stchaker
pushed a commit
to stchaker/openmc
that referenced
this pull request
Oct 25, 2023
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a few more type hints for the meshes.
I am looking to help get a few more features into the meshes including (SphericalMesh.from_domain and bounding boxes for Cylindrical and Spherical) and I think that adding type hints will help when implementing these changes.
Fixes # (issue)
Checklist
- [ ] I have run clang-format on any C++ source files (if applicable)- [ ] I have added tests that prove my fix is effective or that my feature works (if applicable)✔️ I have run
pyteston test_mesh_from_domain.py, test_mesh_from_lattice.py and test_mesh.py