Apply suggestions from code review

Incorporating suggestions from @paulromano Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
paulromano · Dec 24, 2022 · Nov 3, 2022 · Nov 4, 2022 · Nov 4, 2022 · Nov 4, 2022
commit d034e1de9c8fe166f38624ee872b8bc46643c66a
diff --git a/openmc/geometry.py b/openmc/geometry.py
@@ -256,7 +256,7 @@ def from_xml(cls, path='geometry.xml', materials=None):
         ----------
         path : str, optional
             Path to geometry XML file
-         materials : dict
+        materials : dict
             Dictionary mapping material ID strings to :class:`openmc.Material`
             instances (defined in :math:`openmc.Geometry.from_xml`)
 

diff --git a/openmc/model/model.py b/openmc/model/model.py
@@ -228,8 +228,7 @@ def from_model_xml(cls, path='model.xml'):
         model.settings = openmc.Settings.from_xml_element(root.find('settings'))
         model.materials = openmc.Materials.from_xml_element(root.find('materials'))
         materials = {str(m.id): m for m in model.materials}
-        model.geometry = \
-        openmc.Geometry.from_xml_element(root.find('geometry'), materials)
+        model.geometry = .Geometry.from_xml_element(root.find('geometry'), materials)
 
         # gather meshses from other classes before reading the tally node
         meshes = {}
@@ -542,8 +541,7 @@ def export_to_single_xml(self, directory='.', remove_surfs=False):
             materials = openmc.Materials(self.geometry.get_all_materials()
                                          .values())
 
-        with open(d, 'w', encoding='utf-8',
-                  errors='xmlcharrefreplace') as fh:
+        with open(d, 'w', encoding='utf-8', errors='xmlcharrefreplace') as fh:
             # write the XML header
             fh.write("<?xml version='1.0' encoding='utf-8'?>\n")
             fh.write("<model>\n")

diff --git a/tests/regression_tests/model_xml/test.py b/tests/regression_tests/model_xml/test.py
@@ -55,16 +55,16 @@ def _cleanup(self):
 
 
 models = [
-'adj_cell_rotation_model',
-'lattice_mult_model',
-'energy_laws_model',
-'photon_prod_model'
+    'adj_cell_rotation_model',
+    'lattice_mult_model',
+    'energy_laws_model',
+    'photon_prod_model'
 ]
 paths = [
-'../adj_cell_rotation',
-'../lattice_multiple',
-'../energy_laws',
-'../photon_production'
+    '../adj_cell_rotation',
+    '../lattice_multiple',
+    '../energy_laws',
+    '../photon_production'
 ]
 
 

diff --git a/tests/unit_tests/test_model.py b/tests/unit_tests/test_model.py
@@ -7,8 +7,6 @@
 import openmc
 import openmc.lib
 
-from .. import cdtemp
-
 
 @pytest.fixture(scope='function')
 def pin_model_attributes():