Repository navigation

Support for a single `model.xml` file - #2291

Merged

paulromano merged 54 commits into

openmc-dev:developfrom

pshriwise:model-xml

Dec 24, 2022

Merged

Support for a single `model.xml` file#2291
paulromano merged 54 commits into
openmc-dev:developfrom
pshriwise:model-xml

Commits on Dec 6, 2022
- Factor out to_xml_element methods for XML classes
  pshriwise
  committed
  2555b95
- Writing all main nodes to a single XML file
  pshriwise
  committed
  ad746cb
- Writing all output under a single root node
  pshriwise
  committed
  a09a61e
- Keeping old option to write separate XMLs so I can still use to tests to make sure I don't break stuff.
  pshriwise
  committed
  7a9d8c9
- Adding signatures for reading information from an XML node where necessary.
  pshriwise
  committed
  0409652
- Correcting doc scope and some reads
  pshriwise
  committed
  cdd2a6b
- Refactoring model read into it's own function.
  pshriwise
  committed
  bec9bf6
- Factoring out some common lines between reader functions
  pshriwise
  committed
  81aa653
- Adding import for single or multiple XMLs
  pshriwise
  committed
  9391f17
- Fix loop variable overwrite
  pshriwise
  committed
  af6b0af
- Properly call read_plots_xml
  pshriwise
  committed
  5ac6e87
- Other bug fixes
  pshriwise
  committed
  2e71658
- Removing walrus operator
  pshriwise
  committed
  b4dcc30
- Restructureing input function calls a little
  pshriwise
  committed
  611475a
- Adding initial test for exporting model.xmls. Correcting material maps
  pshriwise
  committed
  021bb28
- Correcting doc strings for material mapping sent to
  pshriwise
  committed
  abd3d51
- Running some existing regression tests using single XML file
  pshriwise
  committed
  662d83a
- Making sure meshes are only written once to a model.xml file
  pshriwise
  committed
  1e7dbe9
- Apply suggestions from code review
  
  pshriwise
  and
  paulromano
  committed
  d034e1d
- Addressing some comments from PR
  pshriwise
  committed
  b76825f
- Adding ability to specify an input filename to the executable or to the python exec
  pshriwise
  committed
  d984716
- Test comment and updated error messages
  pshriwise
  committed
  366f9e9
- Addressing a few more comments in C++ code
  pshriwise
  committed
  1e6cb68
- Correcting parenthesis
  pshriwise
  committed
  7a203fb
- Spot check in error message from failed run
  pshriwise
  committed
  fe47d56
- Updating model XML file format w/ indentation.
  pshriwise
  committed
  6f7a6fe
- Addressing some more PR comments. A couple of typo fixes too.
  pshriwise
  committed
  5d1ead2
- Docstring correction and a note about the recursion
  pshriwise
  committed
  e7f95b0
- Adding executor tests
  pshriwise
  committed
  b3225be
- Checking RuntimeError message correctly
  pshriwise
  committed
  72ff942
- Refactoring model_xml regression tests a bit and adding input checking
  pshriwise
  committed
  7f5d2a5
- Reordering geometry XML element attributes
  pshriwise
  committed
  3f4a9eb
- Updating expected inputs with reordering
  pshriwise
  committed
  83cf684
- Moving other relevant XML reorder calls and updating expected input again.
  pshriwise
  committed
  2c27d10
- Updates to import/export methods suggested by @paulromano
  pshriwise
  committed
  cd7c3bf
- Updating handling of single XML input to leverage existing settings::path_input
  pshriwise
  committed
  ef2f690
- Moving Model.from_separate_xmls back to Model.from_xml.
  pshriwise
  committed
  574845b
- Adding function to check if a path is a directory
  pshriwise
  committed
  270331a
- Updates to simplify model filename checking
  pshriwise
  committed
  bc1791d
- Changing name of input argument for Python executor
  pshriwise
  committed
  5634d83
- Docstring correction
  pshriwise
  committed
  d639d1d
- Updating tests to reflect changes to API
  pshriwise
  committed
  939adbe
Commits on Dec 7, 2022
- Some cleanup of file utils
  pshriwise
  committed
  7fdfed2
- Small improvements to read_model_xml
  pshriwise
  committed
  55d77cf
- Update tests/regression_tests/model_xml/test.py
  
  pshriwise
  and
  paulromano
  authored
  7873b4d
- Some housekeeping in the Python classes
  pshriwise
  committed
  ef13643
- Correct use of mesh memo in single XML export
  pshriwise
  committed
  9c942db
- Renaming and docstring/comment updates
  pshriwise
  committed
  916863f
Commits on Dec 13, 2022
- Apply @paulromano suggestions from code review
  
  pshriwise
  and
  paulromano
  authored
  145594e
- Addressing comments from @paulromano
  pshriwise
  committed
  f3bcad3
- Improve comment on recursion arguments
  pshriwise
  committed
  43687e5
Commits on Dec 14, 2022
- Adding mesh memo to Settings.from_xml_element
  pshriwise
  committed
  2eca57a
Commits on Dec 23, 2022
- Several small fixes
  paulromano
  committed
  25f2bd5
- Merge pull request #16 from paulromano/model-xml-pr
  pshriwise
  authored
  64aee3b

Commits

Commits on Dec 6, 2022

Commits on Dec 7, 2022

Commits on Dec 13, 2022

Commits on Dec 14, 2022

Commits on Dec 23, 2022