Skip to content

Add VirusTotal scan results to add-on details #18974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanbudd merged 12 commits into from
Sep 25, 2025
Merged

Add VirusTotal scan results to add-on details #18974

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
368f0ba
Add VirusTotal scan results to add-on details
seanbudd Sep 23, 2025
2f35a28
Pre-commit auto-fix
pre-commit-ci[bot] Sep 23, 2025
16e7ef8
update changes
seanbudd Sep 23, 2025
4a599bb
Merge remote-tracking branch 'origin/addonStoreVirusScan' into addonS…
seanbudd Sep 23, 2025
9373401
better track scans totals
seanbudd Sep 23, 2025
461cfb0
Update user_docs/en/userGuide.md
seanbudd Sep 23, 2025
270a23b
Pre-commit auto-fix
pre-commit-ci[bot] Sep 23, 2025
b02946c
fix trans comment
seanbudd Sep 23, 2025
2e4bf2d
Update source/addonStore/models/scanResults.py
seanbudd Sep 23, 2025
492ac4f
Update user_docs/en/changes.md
seanbudd Sep 25, 2025
5b9d679
Apply suggestions from code review
seanbudd Sep 25, 2025
2d81df6
Merge branch 'master' into addonStoreVirusScan
seanbudd Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
better track scans totals
  • Loading branch information
@seanbudd
seanbudd committed Sep 23, 2025
commit 937340115a30540f6b8af380851f7ac9447a6289
25 changes: 25 additions & 0 deletions source/addonStore/models/scanResults.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,12 @@ class VirusTotalScanResults:
scanUrl: str
malicious: int
undetected: int
harmless: int
suspicious: int
failure: int
timeout: int
confirmedTimeout: int = 0
typeUnsupported: int = 0
Comment thread
seanbudd marked this conversation as resolved.
Outdated

@classmethod
def fromDict(cls, addon: dict[str, Any]) -> "VirusTotalScanResults | None":
Expand All @@ -21,6 +27,25 @@ def fromDict(cls, addon: dict[str, Any]) -> "VirusTotalScanResults | None":
scanUrl=addon["vtScanUrl"],
malicious=analysisStats["malicious"],
undetected=analysisStats["undetected"],
harmless=analysisStats["harmless"],
suspicious=analysisStats["suspicious"],
failure=analysisStats["failure"],
timeout=analysisStats["timeout"],
confirmedTimeout=analysisStats["confirmed-timeout"],
typeUnsupported=analysisStats["type-unsupported"],
)
except KeyError:
return None

@property
def totalScans(self) -> int:
return (
self.malicious
+ self.undetected
+ self.harmless
+ self.suspicious
Comment thread
seanbudd marked this conversation as resolved.
Outdated
)

@property
def totalFlagged(self) -> int:
return self.malicious + self.suspicious
4 changes: 2 additions & 2 deletions source/gui/addonStoreGui/controls/details.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,8 +376,8 @@ def _refresh(self):
"addonStore",
"{malicious} out of {total} malware scanners detected this add-on as malicious.",
Comment thread
seanbudd marked this conversation as resolved.
Outdated
).format(
malicious=details.scanResults.malicious,
total=details.scanResults.malicious + details.scanResults.undetected,
malicious=details.scanResults.totalFlagged,
total=details.scanResults.totalScans,
),
)
self._appendDetailsLabelValue(
Expand Down
Loading