Skip to content

Add VirusTotal scan results to add-on details #18974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanbudd merged 12 commits into from
Sep 25, 2025
Merged

Add VirusTotal scan results to add-on details #18974

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
368f0ba
Add VirusTotal scan results to add-on details
seanbudd Sep 23, 2025
2f35a28
Pre-commit auto-fix
pre-commit-ci[bot] Sep 23, 2025
16e7ef8
update changes
seanbudd Sep 23, 2025
4a599bb
Merge remote-tracking branch 'origin/addonStoreVirusScan' into addonS…
seanbudd Sep 23, 2025
9373401
better track scans totals
seanbudd Sep 23, 2025
461cfb0
Update user_docs/en/userGuide.md
seanbudd Sep 23, 2025
270a23b
Pre-commit auto-fix
pre-commit-ci[bot] Sep 23, 2025
b02946c
fix trans comment
seanbudd Sep 23, 2025
2e4bf2d
Update source/addonStore/models/scanResults.py
seanbudd Sep 23, 2025
492ac4f
Update user_docs/en/changes.md
seanbudd Sep 25, 2025
5b9d679
Apply suggestions from code review
seanbudd Sep 25, 2025
2d81df6
Merge branch 'master' into addonStoreVirusScan
seanbudd Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'master' into addonStoreVirusScan
  • Loading branch information
@seanbudd
seanbudd authored Sep 25, 2025
commit 2d81df6b5d9881532433fe4715ead58217f92686
4 changes: 3 additions & 1 deletion source/addonStore/models/addon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ class _AddonGUIModel(SupportsAddonState, SupportsVersionCheck, Protocol):
description: str
addonVersionName: str
channel: Channel
homepage: Optional[str]
homepage: str | None
changelog: str | None
minNVDAVersion: MajorMinorPatch
lastTestedVersion: MajorMinorPatch
Expand Down Expand Up @@ -117,6 +117,7 @@ class _AddonStoreModel(_AddonGUIModel):
addonVersionName: str
channel: Channel
homepage: str | None
changelog: str | None
minNVDAVersion: MajorMinorPatch
lastTestedVersion: MajorMinorPatch
legacy: bool
Expand Down Expand Up @@ -307,6 +308,7 @@ class AddonStoreModel(_AddonStoreModel):
addonVersionName: str
channel: Channel
homepage: str | None
changelog: str | None
license: str
licenseURL: str | None
sourceURL: str
Expand Down
21 changes: 21 additions & 0 deletions source/gui/addonStoreGui/viewModels/store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,27 @@ def _makeActionsList(self):
actionHandler=lambda aVM: startfile(cast(_AddonStoreModel, aVM.model).scanResults.scanUrl),
Comment thread
seanbudd marked this conversation as resolved.
validCheck=lambda aVM: isinstance(aVM.model, _AddonStoreModel)
and aVM.model.scanResults is not None,
),
AddonActionVM(
# Translators: Label for an action that shows changelog for the selected addon
displayName=pgettext("addonStore", "&What's new"),
actionHandler=lambda aVM: ui.browseableMessage(
markdown(
str(
cast(_AddonStoreModel, aVM.model).changelog,
),
),
# Translators: Title for a message showing changes for the current add-on version.
title=pgettext("addonStore", "Changes for {curVersion}").format(
curVersion=aVM.model.addonVersionName,
),
isHtml=True,
copyButton=True,
closeButton=True,
),
validCheck=lambda aVM: (
isinstance(aVM.model, _AddonStoreModel) and aVM.model.changelog is not None
),
actionTarget=selectedListItem,
),
]
Expand Down
1 change: 1 addition & 0 deletions user_docs/en/changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ This can be enabled using the "Report when lists support multiple selection" set
* While reading text, spelling errors can now be reported with a sound instead of speech. (#4233, @jcsteh, @CyrilleB79)
* VirusTotal scan results are now available in the details for an add-on in the Add-on Store.
An action has been added to view the full scan results on the VirusTotal website. (#18974)
* In the Add-on Store, a new action has been added to see the latest changes for the current version of add-ons. (#14041, @josephsl, @nvdaes)

### Changes

Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.