Skip to content

Fix audio output device selection #17532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SaschaCowley merged 7 commits into from
Dec 18, 2024
Merged

Fix audio output device selection #17532

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d3853f1
Fix default device detection
SaschaCowley Dec 16, 2024
90f0cbc
Improve type hints and make DEFAULT_DEVICE_KEY pull directly from con…
SaschaCowley Dec 16, 2024
ad90022
Removed unneeded initialisation parameters
SaschaCowley Dec 16, 2024
108f073
Removed unneeded symbols
SaschaCowley Dec 16, 2024
edaa869
Updated changes
SaschaCowley Dec 16, 2024
4912899
Update user_docs/en/changes.md
SaschaCowley Dec 17, 2024
ed852ef
Update user_docs/en/changes.md
SaschaCowley Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update user_docs/en/changes.md
  • Loading branch information
@SaschaCowley
SaschaCowley authored Dec 17, 2024
commit ed852efff8d3c318bc1b8cc97621b9f4adc5da6e
2 changes: 1 addition & 1 deletion user_docs/en/changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ As the NVDA update check URL is now configurable directly within NVDA, no replac
* `SymphonyDocument.script_toggleTextAttribute` to `SymphonyDocument.script_changeTextFormatting`
* The `space` keyword argument for `brailleDisplayDrivers.seikantk.InputGesture` now expects an `int` rather than a `bool`. (#17047, @school510587)
* The `[upgrade]` configuration section including `[upgrade][newLaptopKeyboardLayout]` has been removed. (#17191)
* Due to the retirement of NVDA's winmm support:
* Due to the retirement of NVDA's winmm support (#17496, #17532):
* The following symbols have been removed from `nvwave`: `CALLBACK_EVENT`, `CALLBACK_FUNCTION`, `CALLBACK_NULL`, `HWAVEOUT`, `LPHWAVEOUT`, `LPWAVEFORMATEX`, `LPWAVEHDR`, `MAXPNAMELEN`, `MMSYSERR_NOERROR`, `usingWasapiWavePlayer`, `WAVEHDR`, `WAVEOUTCAPS`, `waveOutProc`, `WAVE_MAPPER`, `WHDR_DONE`, `WinmmWavePlayer`, and `winmm`.
* `gui.settingsDialogs.AdvancedPanelControls.wasapiComboBox` has been removed.
* The `WASAPI` key has been removed from the `audio` section of the config spec.
Expand Down