Skip to content

Fix audio output device selection #17532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SaschaCowley merged 7 commits into from
Dec 18, 2024
Merged

Fix audio output device selection #17532

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d3853f1
Fix default device detection
SaschaCowley Dec 16, 2024
90f0cbc
Improve type hints and make DEFAULT_DEVICE_KEY pull directly from con…
SaschaCowley Dec 16, 2024
ad90022
Removed unneeded initialisation parameters
SaschaCowley Dec 16, 2024
108f073
Removed unneeded symbols
SaschaCowley Dec 16, 2024
edaa869
Updated changes
SaschaCowley Dec 16, 2024
4912899
Update user_docs/en/changes.md
SaschaCowley Dec 17, 2024
ed852ef
Update user_docs/en/changes.md
SaschaCowley Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed unneeded initialisation parameters
  • Loading branch information
@SaschaCowley
SaschaCowley committed Dec 16, 2024
commit ad90022a51ff6f309849c6a0c549b9fc57c09c55
7 changes: 1 addition & 6 deletions source/nvwave.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,20 +267,15 @@ def __init__(
samplesPerSec: int,
bitsPerSample: int,
outputDevice: str = DEFAULT_DEVICE_KEY,
closeWhenIdle: bool = False,
wantDucking: bool = True,
buffered: bool = False,
purpose: AudioPurpose = AudioPurpose.SPEECH,
):
"""Constructor.
@param channels: The number of channels of audio; e.g. 2 for stereo, 1 for mono.
@param samplesPerSec: Samples per second (hz).
@param bitsPerSample: The number of bits per sample.
@param outputDevice: The name of the audio output device to use,
WAVE_MAPPER for default.
@param closeWhenIdle: Deprecated; ignored.
@param outputDevice: The name of the audio output device to use, defaults to WasapiWavePlayer.DEFAULT_DEVICE_KEY
@param wantDucking: if true then background audio will be ducked on Windows 8 and higher
@param buffered: Whether to buffer small chunks of audio to prevent audio glitches.
@param purpose: The purpose of this audio.
@note: If C{outputDevice} is a name and no such device exists, the default device will be used.
@raise WindowsError: If there was an error opening the audio output device.
Expand Down
1 change: 0 additions & 1 deletion source/synthDrivers/_espeak.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,6 @@ def initialize(indexCallback=None):
samplesPerSec=sampleRate,
bitsPerSample=16,
outputDevice=config.conf["speech"]["outputDevice"],
buffered=True,
)
onIndexReached = indexCallback
espeakDLL.espeak_SetSynthCallback(callback)
Expand Down