Skip to content

Make target for @overload have 'generic' as default. #8554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sklam merged 2 commits into from
Nov 4, 2022
Merged

Make target for @overload have 'generic' as default. #8554

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3ecb1f
Make overload target generic
gmarkall Oct 25, 2022
4e77659
Set `@overload` "default" behaviour of `nopython=True`.
stuartarchibald Oct 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Set @overload "default" behaviour of nopython=True. 
As title. This preserves the historical behaviour of `@overload`
having the kwarg default of `nopython=True`. Without this,
`@overload`s that end up with `literally` calls in their path can
refuse to resolve as `object-mode` fallback occurs and there's no
compiler pass for handling `literally` calls in that mode.
  • Loading branch information
@stuartarchibald
stuartarchibald committed Oct 31, 2022
commit 4e776598f53fe5fd7d72f765b18f63da787f4992
6 changes: 4 additions & 2 deletions numba/core/extending.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,10 @@ def generic(self):


# By default, an *overload* does not have a cpython wrapper because it is not
# callable from python.
_overload_default_jit_options = {'no_cpython_wrapper': True}
# callable from python. It also has `nopython=True`, this has been default since
# its inception!
_overload_default_jit_options = {'no_cpython_wrapper': True,
'nopython':True}


def overload(func, jit_options={}, strict=True, inline='never',
Expand Down