Repository navigation
Make target for @overload have 'generic' as default. - #8554
Merged
sklam merged 2 commits intoNov 4, 2022
Merged
Conversation
As title. This preserves the historical behaviour of `@overload` having the kwarg default of `nopython=True`. Without this, `@overload`s that end up with `literally` calls in their path can refuse to resolve as `object-mode` fallback occurs and there's no compiler pass for handling `literally` calls in that mode.
Member
|
gpuci run tests |
stuartarchibald
marked this pull request as ready for review
November 4, 2022 10:35
stuartarchibald
added
3 - Ready for Review
Effort - short
Contributor
Author
gmarkall
approved these changes
Nov 4, 2022
gmarkall
left a comment
gmarkall
left a comment
Member
There was a problem hiding this comment.
This looks good to me, though I agree with what was said OOB about a buildfarm run being a good idea first.
gmarkall
added
Pending BuildFarm
Member
|
|
Member
This was fine. |
gmarkall
added
BuildFarm Passed
Member
|
@esc Many thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the default
targetfor@overloadthe'generic'target, as, in effect, very few@overloadimplementations are genuinely target specific. Further, the use of the standardnumba.jitwrapper (with notargetset) for@overloadimplementations leads to strange cases where some function cannot be resolved on e.g. the CUDA target, but because there's no target set in thejitwrapper the error message cannot tell you why, it just materialises as a lowering error (i.e. this should fix #8530).The first commit in this PR (a3ecb1f) is from @gmarkall's Numba fork on branch
overload-target-generic, the corresponding commit is: 38b5379, authorship is preserved, many thanks @gmarkall!