Skip to content

Fix grammar in troubleshoot.rst - #8527

Merged
sklam merged 2 commits into
numba:mainfrom
armgabrielyan:patch-3
Oct 25, 2022
Merged

sklam merged 2 commits into
numba:mainfrom
armgabrielyan:patch-3

Conversation

@armgabrielyan

Copy link
Copy Markdown
Contributor

Fix grammar in documentation on Troubleshooting and tips.

@stuartarchibald stuartarchibald left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these typos, one thing to resolve RE linewrap else look good.

Comment thread docs/source/user/troubleshoot.rst Outdated
-----------------------------

The follow example is quite involved, it executes with ``gdb`` instrumentation
The following example is quite involved, it executes with ``gdb`` instrumentation

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could this be line wrapped to 80 characters? Many thanks.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment! I have made the appropriate changes. Could you please check it out?

@stuartarchibald stuartarchibald added 4 - Waiting on author Waiting for author to respond to review and removed 3 - Ready for Review labels Oct 24, 2022
@stuartarchibald stuartarchibald self-assigned this Oct 24, 2022
@stuartarchibald stuartarchibald added this to the Numba 0.57 RC milestone Oct 24, 2022

@stuartarchibald stuartarchibald left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch and fixes!

@stuartarchibald stuartarchibald added 5 - Ready to merge Review and testing done, is ready to merge and removed 4 - Waiting on author Waiting for author to respond to review labels Oct 25, 2022
@armgabrielyan

Copy link
Copy Markdown
Contributor Author

Thank you!

@sklam
sklam merged commit 40140f5 into numba:main Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 - Ready to merge Review and testing done, is ready to merge Effort - short Short size effort needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants