Repository navigation
Make C++ extensions compile with correct compiler - #8389
Merged
Merged
Conversation
Some extension files are C++ but have `.c` extensions. GCC will compile these as C++, but clang will not.
stuartarchibald
left a comment
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch @apmasell. I've taken a look through the C/C++ code changes, specifically at things like type casts and the proposed changes seem valid on inspection.
stuartarchibald
added
4 - Waiting on second reviewer
gmarkall
previously approved these changes
Sep 13, 2022
gmarkall
left a comment
gmarkall
left a comment
Member
There was a problem hiding this comment.
This looks good to me - I'm approving it, though I note Stuart's suggestion about the formatting of the pointers on the diff.
gmarkall
added
4 - Waiting on author
As titled Co-authored-by: stuartarchibald <stuartarchibald@users.noreply.github.com>
Contributor
Author
|
Accepted the suggestion. Might be worth extending the formatting from llvmlite to numba. |
stuartarchibald
approved these changes
Sep 13, 2022
stuartarchibald
added
5 - Ready to merge
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some extension files are C++ but have
.cextensions. GCC will compile theseas C++, but clang will not.