Repository navigation
Conversation
Member
Author
|
cc @dlee992 |
2 tasks done
Member
Author
|
I think the issues this attempted to solve were addressed by #8389. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typeconv.cppnow uses C++11 features, but it manages to skip getting the-std=c++11flag on Darwin because it's built as an extension that includes both C and C++ files, so we can't just add the flag toextra_compile_args. Instead this attempts to sneak the flag into the C++ compiler specification just before extensions are built.Testing on CI for now.