Skip to content

remove upper limit on Python version - #7783

Merged
sklam merged 1 commit into
numba:mainfrom
esc:fix-python-requires
Apr 14, 2022
Merged

remove upper limit on Python version#7783
sklam merged 1 commit into
numba:mainfrom
esc:fix-python-requires

Conversation

@esc

@esc esc commented Jan 25, 2022

Copy link
Copy Markdown
Member

As suggested on
https://discuss.python.org/t/requires-python-upper-limits/12663 and on

numba/llvmlite#693 (comment)

we should not use Requires-Python to set an upper limit.

@esc
remove upper limit on Python version
52420c4 
As suggested on
https://discuss.python.org/t/requires-python-upper-limits/12663 and on

numba/llvmlite#693 (comment)

we should not use `Requires-Python` to set an upper limit.
@esc esc added 3 - Ready for Review Effort - short Short size effort needed labels Jan 25, 2022
@esc

esc commented Jan 25, 2022

Copy link
Copy Markdown
Member Author

@henryiii can you take a look at this one when you have a minute? Thank you!

@stuartarchibald stuartarchibald added this to the Numba 0.56 RC milestone Jan 26, 2022
@henryiii

henryiii commented Jan 27, 2022

Copy link
Copy Markdown
Contributor

This looks good to me, though it needs to happen on llvmlite, too. https://github.com/numba/llvmlite/blob/aeddf447d4befc336b26bde8c46042553a13cf75/setup.py#L226-L227 Though even without that, this is probably better than the current behavior.

@stuartarchibald

stuartarchibald commented Jan 28, 2022

Copy link
Copy Markdown
Contributor

Any suggestions for how to test this?

@henryiii

henryiii commented Jan 28, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

You can do a one-time test by using pip download to grab a couple of existing releases (one with the limit, one before the limit) and put it in a wheelhouse folder. You can also make a wheel for this PR with python -m build --wheel or pip wheel . and drop that into the wheelhouse folder too. Then try to pip install with --no-index & --find-links=<wheelhouse>. Probably --dev too if the current wheel has a dev version.

You could bundle these into a fixture for PyTest, which I've done for other things, but this is not something that is probably worth adding to continuous testing for this? See https://github.com/scikit-build/scikit-build/blob/47a61e7aca8e4b37f390503df49363013829f81a/tests/conftest.py#L14-L29.

@esc

esc commented Feb 1, 2022

Copy link
Copy Markdown
Member Author

The llvmlite followup is here: numba/llvmlite#817

@sklam

sklam commented Apr 4, 2022

Copy link
Copy Markdown
Member

numba/llvmlite#817 merged

@esc esc mentioned this pull request Apr 5, 2022
Merged
@esc

esc commented Apr 6, 2022

Copy link
Copy Markdown
Member Author

@sklam will this one be merged soon too?

sklam
sklam approved these changes Apr 14, 2022
View reviewed changes

@sklam sklam left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sklam sklam added 5 - Ready to merge Review and testing done, is ready to merge and removed 3 - Ready for Review labels Apr 14, 2022
@sklam
sklam merged commit a729e26 into numba:main Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sklam sklam sklam approved these changes
@stuartarchibald stuartarchibald Awaiting requested review from stuartarchibald

Assignees

No one assigned

Labels

5 - Ready to merge Review and testing done, is ready to merge Effort - short Short size effort needed

Projects

None yet

Milestone

Numba 0.56 RC

Development

Successfully merging this pull request may close these issues.

4 participants

@esc @henryiii @stuartarchibald @sklam