Skip to content

remove uppper limit on Python requires - #817

Merged
sklam merged 1 commit into
numba:mainfrom
esc:remove_upper_bound_python_requires
Apr 4, 2022
Merged

sklam merged 1 commit into
numba:mainfrom
esc:remove_upper_bound_python_requires

Conversation

@esc

@esc esc commented Feb 1, 2022

Copy link
Copy Markdown
Member

As title

@sklam

sklam commented Apr 4, 2022

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines successfully started running 1 pipeline(s).

@sklam sklam left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sklam
sklam merged commit 8ffac1f into numba:main Apr 4, 2022
@esc

esc commented Apr 5, 2022

Copy link
Copy Markdown
Member Author

For reference, the discussion leading up to this change are here: numba/numba#7783 (comment)

The TL;DR on this is: if this patch were in released version of llvmlite and if Python 3.11 was suddenly released today, then: anyone trying to install llvmllite with pip would be able to install it fine, but would receive a runtime warning that the version of Python isn't compatible (even though it probably would be, but that is for another ticket). This was deemed better than the previous behaviour, which would cause pip to look at previous versions of llvmlite until it found one that doesn't pin Python this way (some ancient version) and then try to install that, either failing hopelessly or leaving the user confused.

@esc
esc deleted the remove_upper_bound_python_requires branch May 31, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants