Skip to content

Add support for np.broadcast_arrays #7660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sklam merged 14 commits into from
Apr 1, 2022
Merged

Add support for np.broadcast_arrays #7660

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
af818d0
add support for np.broadcast_arrays
guilhermeleobas Dec 15, 2021
b7d86b8
update test
guilhermeleobas Dec 15, 2021
a476255
update test
guilhermeleobas Dec 15, 2021
e2bae6e
fix for 32-bit system
guilhermeleobas Dec 16, 2021
c4a5a4d
remove build_int_tuple
guilhermeleobas Jan 26, 2022
00c24de
reorder tests
guilhermeleobas Jan 26, 2022
e240368
restrict input types and add tests
guilhermeleobas Feb 2, 2022
243d8e8
update test
guilhermeleobas Feb 2, 2022
6b7fa64
remove StringLiteral and Boolean
guilhermeleobas Feb 18, 2022
6089e91
raise typeerror
guilhermeleobas Mar 8, 2022
f36ce65
add support for tuple
guilhermeleobas Mar 28, 2022
a81c4fb
adjust test
guilhermeleobas Mar 28, 2022
faea5d0
Fix test
guilhermeleobas Mar 28, 2022
a7292d1
Update numba/tests/test_array_manipulation.py
guilhermeleobas Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove StringLiteral and Boolean
  • Loading branch information
@guilhermeleobas
guilhermeleobas committed Feb 18, 2022
commit 6b7fa648977b42cdd8d694daf26c279aa4c3752d
3 changes: 1 addition & 2 deletions numba/np/arrayobj.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1410,8 +1410,7 @@ def numpy_broadcast_arrays(*args):
for idx, arg in enumerate(args):
if isinstance(arg, types.ArrayCompatible):
m = max(m, arg.ndim)
elif isinstance(arg, (types.Number, types.StringLiteral,
types.Boolean)):
elif isinstance(arg, types.Number):
m = max(m, 1)
Comment on lines +1425 to +1429

@stuartarchibald stuartarchibald Mar 28, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This unfortunately doesn't work:

from numba import njit
import numpy as np

@njit
def foo(tupl):
    return np.broadcast_arrays(tupl, tupl)

print(foo((1,2)))

I think the issue is that this loop is not handling tuple types? Probably needs something like:

        elif isinstance(arg, types.BaseTuple):
            m = max(m, arg.count)

?

@guilhermeleobas guilhermeleobas Mar 28, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed


# m = max([arr.ndim for arr in args])
Expand Down