Add support for np.broadcast_arrays by guilhermeleobas · Pull Request #7660 · numba/numba

guilhermeleobas · 2021-12-15T19:09:24Z

As title

guilhermeleobas · 2022-01-10T16:04:39Z

PR is ready for review. @gmarkall, can you please change the label?

stuartarchibald

Thanks for the patch, I've given this an initial review, the impl and testing look like they cover the use case broadcast_arrays() with one arg, but I think some refactoring could help further. Thanks again!

guilhermeleobas · 2022-01-28T16:40:28Z

@stuartarchibald, when you have some time, can you update the label in this PR?

stuartarchibald

Thanks for the patch. I've given this an initial review to provide some feedback and have left this inline. Once addressed I'd like to take another look to see if there's any corner cases that are potentially missing as the tests equivalent to those from NumPy seem to cover a lot of things but there may be some Numba specific issues. Thanks again!

guilhermeleobas · 2022-02-07T16:58:35Z

@stuartarchibald, when you have some time, can you update the label in this PR?

stuartarchibald

Thanks for the updates @guilhermeleobas. I've made a couple more remarks in relation to what is supported/not supported, please could you take a look? Many thanks.

stuartarchibald

Thanks for the update. There seems to be a remaining issue with handling tuples but otherwise this looks good.

stuartarchibald · 2022-03-28T11:41:27Z

+    for idx, arg in enumerate(args):
+        if isinstance(arg, types.ArrayCompatible):
+            m = max(m, arg.ndim)
+        elif isinstance(arg, (types.Number, types.Boolean)):
+            m = max(m, 1)


This unfortunately doesn't work:

from numba import njit import numpy as np @njit def foo(tupl): return np.broadcast_arrays(tupl, tupl) print(foo((1,2)))

I think the issue is that this loop is not handling tuple types? Probably needs something like:

elif isinstance(arg, types.BaseTuple): m = max(m, arg.count)

?

guilhermeleobas · 2022-03-28T17:15:48Z

Failure is not related to the changes introduced in this PR.

stuartarchibald

Thanks for the update. One minor style alignment issue to fix, then will mark for merge.

Co-authored-by: stuartarchibald <stuartarchibald@users.noreply.github.com>

guilhermeleobas · 2022-03-29T19:09:52Z

@stuartarchibald done!

stuartarchibald

Thanks for the patch and fixes.

guilhermeleobas added 3 commits December 15, 2021 17:38

add support for np.broadcast_arrays

af818d0

update test

b7d86b8

update test

a476255

guilhermeleobas force-pushed the guilhermeleobas/np-broadcast_arrays branch from bfe955a to a476255 Compare December 15, 2021 20:38

gmarkall added the 2 - In Progress label Dec 16, 2021

fix for 32-bit system

e2bae6e

guilhermeleobas marked this pull request as ready for review December 16, 2021 17:07

guilhermeleobas requested review from esc, sklam and stuartarchibald as code owners December 16, 2021 17:07

stuartarchibald added 3 - Ready for Review and removed 2 - In Progress labels Jan 10, 2022

gmarkall added this to the Numba 0.56 RC milestone Jan 11, 2022

stuartarchibald reviewed Jan 24, 2022

View reviewed changes

Comment thread numba/np/arrayobj.py Outdated

Comment thread numba/tests/test_array_manipulation.py

stuartarchibald added 4 - Waiting on author Waiting for author to respond to review Effort - medium Medium size effort needed and removed 3 - Ready for Review labels Jan 24, 2022

guilhermeleobas added 2 commits January 26, 2022 13:26

remove build_int_tuple

c4a5a4d

reorder tests

00c24de

stuartarchibald added 4 - Waiting on reviewer Waiting for reviewer to respond to author and removed 4 - Waiting on author Waiting for author to respond to review labels Jan 28, 2022

stuartarchibald reviewed Feb 1, 2022

View reviewed changes

Comment thread numba/np/arrayobj.py Outdated

Comment thread numba/np/arrayobj.py

Comment thread numba/tests/test_array_manipulation.py

stuartarchibald added 4 - Waiting on author Waiting for author to respond to review and removed 4 - Waiting on reviewer Waiting for reviewer to respond to author labels Feb 1, 2022

guilhermeleobas added 2 commits February 2, 2022 13:36

restrict input types and add tests

e240368

update test

243d8e8

stuartarchibald removed the 4 - Waiting on author Waiting for author to respond to review label Feb 7, 2022

stuartarchibald added the 4 - Waiting on reviewer Waiting for reviewer to respond to author label Feb 7, 2022

stuartarchibald reviewed Feb 18, 2022

View reviewed changes

Comment thread numba/np/arrayobj.py Outdated

Comment thread numba/np/arrayobj.py Outdated

stuartarchibald added 4 - Waiting on author Waiting for author to respond to review and removed 4 - Waiting on reviewer Waiting for reviewer to respond to author labels Feb 18, 2022

guilhermeleobas added 2 commits February 18, 2022 14:46

remove StringLiteral and Boolean

6b7fa64

raise typeerror

6089e91

stuartarchibald reviewed Mar 28, 2022

View reviewed changes

guilhermeleobas added 3 commits March 28, 2022 11:26

add support for tuple

f36ce65

adjust test

a81c4fb

Fix test

faea5d0

stuartarchibald reviewed Mar 29, 2022

View reviewed changes

Comment thread numba/tests/test_array_manipulation.py Outdated

Update numba/tests/test_array_manipulation.py

a7292d1

Co-authored-by: stuartarchibald <stuartarchibald@users.noreply.github.com>

esc added 4 - Waiting on reviewer Waiting for reviewer to respond to author and removed 4 - Waiting on author Waiting for author to respond to review labels Mar 30, 2022

stuartarchibald approved these changes Mar 30, 2022

View reviewed changes

stuartarchibald added 5 - Ready to merge Review and testing done, is ready to merge and removed 4 - Waiting on reviewer Waiting for reviewer to respond to author labels Mar 30, 2022

sklam merged commit 55361c7 into numba:main Apr 1, 2022

Conversation

guilhermeleobas commented Dec 15, 2021

Uh oh!

guilhermeleobas commented Jan 10, 2022

Uh oh!

stuartarchibald left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

guilhermeleobas commented Jan 28, 2022

Uh oh!

stuartarchibald left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

guilhermeleobas commented Feb 7, 2022

Uh oh!

stuartarchibald left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

stuartarchibald left a comment

Choose a reason for hiding this comment

Uh oh!

stuartarchibald Mar 28, 2022

Choose a reason for hiding this comment

Uh oh!

guilhermeleobas Mar 28, 2022

Choose a reason for hiding this comment

Uh oh!

guilhermeleobas commented Mar 28, 2022

Uh oh!

stuartarchibald left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

guilhermeleobas commented Mar 29, 2022

Uh oh!

stuartarchibald left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants