Repository navigation
Fix TBB 2021 DSO names on OSX/Win and make TBB reporting consistent - #7605
Merged
Merged
Conversation
gmarkall
reviewed
Nov 29, 2021
| # first check that the TBB version is new enough | ||
| if _IS_WINDOWS: | ||
| libtbb_name = 'tbb' | ||
| libtbb_name = 'tbb12.dll' |
Member
There was a problem hiding this comment.
What happens if there is an older TBB version? Was there a previous version of TBB where the library was named tbb.dll that would be missed now?
Member
There was a problem hiding this comment.
... or was this just always wrong?
Contributor
Author
There was a problem hiding this comment.
TBB changed ABI for the 2021 series. Numba updated to requiring this version as a minimum in 0.54. in associated PR #6854. I guess the windows and osx library name changes were missed.
Contributor
Author
There was a problem hiding this comment.
Am trying to enforce some consistency in #7606, whereby the CI system checks that if a threading layer is requested that it can actually be loaded.
stuartarchibald
added
3 - Ready for Review
Effort - short
sklam
reviewed
Dec 6, 2021
| libtbb_name = 'tbb12.dll' | ||
| elif _IS_OSX: | ||
| libtbb_name = 'libtbb.dylib' | ||
| libtbb_name = 'libtbb.12.dylib' |
stuartarchibald
added
5 - Ready to merge
Contributor
Author
|
Thanks for the review @sklam. |
stuartarchibald
added a commit
to stuartarchibald/numba
that referenced
this pull request
Dec 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title.
Fixes #7600