Skip to content

PR 6096 continued - #6854

Merged
sklam merged 10 commits into
numba:masterfrom
stuartarchibald:pr_6096_continued
Mar 26, 2021
Merged

sklam merged 10 commits into
numba:masterfrom
stuartarchibald:pr_6096_continued

Conversation

@stuartarchibald

@stuartarchibald stuartarchibald commented Mar 23, 2021 •

Copy link
Copy Markdown
Contributor

Continues #6096...

  • Adds public CI support
  • Updates conda recipes
  • Removes Python 3 version guards
  • Removes references/support for TBB < 2021.

* Python < 3 code removed.
* Code relating to old ABI tbb removed, version guards updated.
As title
@stuartarchibald

Copy link
Copy Markdown
Contributor Author

@Hardcode84 Are you happy with the contents of this patch? It's essentially a reduced version of #6096, TBB minimum version is raised to 2021 version 1.

@Hardcode84

Copy link
Copy Markdown

LGTM

@stuartarchibald

Copy link
Copy Markdown
Contributor Author

LGTM

@Hardcode84 Thanks for checking.

@stuartarchibald

Copy link
Copy Markdown
Contributor Author

Buildfarm ID: numba_smoketest_cpu_yaml_12.

@stuartarchibald

Copy link
Copy Markdown
Contributor Author

Buildfarm ID: numba_smoketest_cpu_yaml_12.

This passed.

@stuartarchibald stuartarchibald added the Effort - medium Medium size effort needed label Mar 26, 2021

@sklam sklam left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sklam sklam added 5 - Ready to merge Review and testing done, is ready to merge BuildFarm Passed For PRs that have been through the buildfarm and passed and removed 3 - Ready for Review labels Mar 26, 2021
@sklam
sklam merged commit 52e52e7 into numba:master Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 - Ready to merge Review and testing done, is ready to merge BuildFarm Passed For PRs that have been through the buildfarm and passed Effort - medium Medium size effort needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants