Repository navigation
Fix list.insert() for refcounted values - #7603
Merged
Merged
Conversation
stuartarchibald
added
3 - Ready for Review
Effort - short
esc
approved these changes
Dec 14, 2021
esc
left a comment
esc
left a comment
Member
There was a problem hiding this comment.
Thank you for this fix. I have tried running the test w/o the fix applied and I receive:
python(26644,0x112ca8dc0) malloc: Incorrect checksum for freed object 0x7f957ce5ec80: probably modified after being freed.
Corrupt value: 0x9fffffffffffffff
python(26644,0x112ca8dc0) malloc: *** set a breakpoint in malloc_error_break to debug
Fatal Python error: Aborted
Current thread 0x0000000112ca8dc0 (most recent call first):
<no Python frame>
But, with the fix applied, the test passes fine. So I am giving this the green light to merge.
esc
added
5 - Ready to merge
sklam
approved these changes
Dec 14, 2021
sklam
left a comment
sklam
left a comment
Member
There was a problem hiding this comment.
Thanks for the patch!
I give a 15minute attempt to see if calling zfill in move would be more elegant and I am stuck with the case of moving the slots backward. So, it can be a future thing to revisit but we need to fix this bug now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7553.
Reference an existing issue