Repository navigation
List.insert() crashes for Numpy arrays #7553
Description
Reporting a bug
- I have tried using the latest released version of Numba (most recent is
visible in the change log (https://github.com/numba/numba/blob/master/CHANGE_LOG). - I have included a self contained code sample to reproduce the problem.
i.e. it's possible to run as 'python bug.py'.
This code segfaults for me (on Mac OS). Didn't see an obvious issue in insert's implementation with a quick look.
import numpy as np
import numba
@numba.njit
def f():
l = [np.ones(3)]
l.insert(0, np.ones(3))
return l
f()
Activity
ehsantn commentedon Nov 11, 2021
I think I found the issue. The setitem call here decrefs the old value but it shouldn't. I'd be happy to submit a PR if this sounds correct.
numba/numba/cpython/listobj.py
Line 982 in 805e24f
esc commentedon Nov 12, 2021
@ehsantn thank you for raising this. Will the suggested fix take care of the segfault? If so, please do prepare a PR so we can run it though CI? What kind of patch would you propose?
BTW: I can confirm I am able to reproduce this on OSX with Python 3.9 and current
HEADat5fc9d3c56da4e4c6aef7189e588ce9c44263d4a6.ehsantn commentedon Nov 13, 2021
Yes, it fixes the segfault. It's a small change. Will open a PR soon.
esc commentedon Nov 13, 2021
Thank you! 🙏
github-actions commentedon Dec 14, 2021
This issue is marked as stale as it has had no activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with any updates and confirm that this issue still needs to be addressed.
ehsantn commentedon Dec 14, 2021
Linking a pull request doesn't count as activity?
esc commentedon Dec 14, 2021
@ehsantn apparently not, no.
esc commentedon Dec 14, 2021
it was the
needtriagelabel that triggered stale-bot, I have removed it now.