Repository navigation
CUDA: Skip managed alloc tests on ARM - #7236
Merged
Merged
Conversation
Managed allocation does work on AArch64, but the tests cause some problems on various different Tegra devices. Given the lack of AArch64 testing capability, for now we'll skip the tests on ARM and note that the support is considered "experimental". Fixes numba#7180.
gmarkall
added
3 - Ready for Review
CUDA
Member
Author
|
(See also #7189 which also adds the |
sklam
reviewed
Jul 28, 2021
|
|
||
| @skip_on_cudasim('CUDA Driver API unsupported in the simulator') | ||
| @linux_only | ||
| @skip_on_arm |
sklam
added
4 - Waiting on author
Member
Author
|
@sklam Thanks for the review - I've now added a skip reason |
gmarkall
added
4 - Waiting on reviewer
sklam
approved these changes
Jul 29, 2021
sklam
left a comment
sklam
left a comment
Member
There was a problem hiding this comment.
Confirmed skip working on jetson nano
sklam
added
4 - Waiting on CI
Member
|
BFID |
Member
|
BF passed |
sklam
added
5 - Ready to merge
sklam
added a commit
to sklam/numba
that referenced
this pull request
Aug 4, 2021
CUDA: Skip managed alloc tests on ARM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Managed allocation does work on AArch64, but the tests cause some problems on various different Tegra devices. Given the lack of AArch64 testing capability, for now we'll skip the tests on ARM and note that the support is considered "experimental".
Fixes #7180.