Skip to content

CUDA: Skip managed alloc tests on ARM #7236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sklam merged 2 commits into from
Jul 30, 2021
+11 −3
Merged

CUDA: Skip managed alloc tests on ARM #7236

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60ffc45
CUDA: Skip managed alloc tests on ARM
gmarkall Jul 22, 2021
db5a12f
Add reason for skipping TestManagedAlloc on ARM
gmarkall Jul 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions numba/cuda/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,8 @@ def managed_array(shape, dtype=np.float_, strides=None, order='C', stream=0,
Allocate a np.ndarray with a buffer that is managed.
Similar to np.empty().

Managed memory is supported on Linux, and is considered experimental on
Windows.
Managed memory is supported on Linux / x86 and PowerPC, and is considered
experimental on Windows and Linux / AArch64.

:param attach_global: A flag indicating whether to attach globally. Global
attachment implies that the memory is accessible from
Expand Down
7 changes: 7 additions & 0 deletions numba/cuda/testing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import contextlib
import os
import platform
import shutil
import sys

Expand Down Expand Up @@ -99,6 +100,12 @@ def skip_with_nvdisasm(reason):
return unittest.skipIf(nvdisasm_path is not None, reason)


def skip_on_arm(reason):
cpu = platform.processor()
is_arm = cpu.startswith('arm') or cpu.startswith('aarch')
return unittest.skipIf(is_arm, reason)


def cc_X_or_above(major, minor):
if not config.ENABLE_CUDASIM:
cc = devices.get_context().device.compute_capability
Expand Down
3 changes: 2 additions & 1 deletion numba/cuda/tests/cudadrv/test_managed_alloc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,13 @@
from numba.cuda.cudadrv.driver import device_memset, driver
from numba import cuda
from numba.cuda.testing import unittest, ContextResettingTestCase
from numba.cuda.testing import skip_on_cudasim
from numba.cuda.testing import skip_on_cudasim, skip_on_arm
from numba.tests.support import linux_only


@skip_on_cudasim('CUDA Driver API unsupported in the simulator')
@linux_only
@skip_on_arm

@sklam sklam Jul 28, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect use. Missing reason.

@gmarkall gmarkall Jul 29, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops!

class TestManagedAlloc(ContextResettingTestCase):

def get_total_gpu_memory(self):
Expand Down