Skip to content

gh #7131 Support for astype with literal strings #7132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sklam merged 9 commits into from
Oct 6, 2021
Merged

gh #7131 Support for astype with literal strings #7132

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7abe006
gh #7131 support for astype with literal strings
Jun 21, 2021
7e86ad9
numba/core/types/functions.py
Jul 9, 2021
1646701
updated arraydecl to throw require literal value
Jul 9, 2021
a8e24a9
reverted function changes
Jul 9, 2021
1551c2a
fixed import issue
Aug 3, 2021
82062a8
Added a test that unicode value must be a string literal
Sep 9, 2021
2c8fa0a
Made Stuart's changes
Oct 5, 2021
f7665e4
fixed typo
Oct 5, 2021
97a54df
Update numba/core/typing/arraydecl.py
njriasan Oct 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions numba/core/types/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,6 @@ def get_call_type(self, context, args, kws):
literal_e = None
nonliteral_e = None
out = None

Comment thread
stuartarchibald marked this conversation as resolved.
Resolved
choice = [True, False] if template.prefer_literal else [False, True]
for uselit in choice:
if uselit:
Expand Down Expand Up @@ -442,7 +441,10 @@ def get_call_type(self, context, args, kws):
raise exc
nonliteral_e = exc
else:
break
# If out returns None don't break as we may need to use
# a literal.
if out is not None:
break
Comment thread
stuartarchibald marked this conversation as resolved.
Resolved

if out is None and (nonliteral_e is not None or literal_e is not None):
header = "- Resolution failure for {} arguments:\n{}\n"
Expand Down
1 change: 1 addition & 0 deletions numba/np/arrayobj.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4146,6 +4146,7 @@ def array_ascontiguousarray(context, builder, sig, args):


@lower_builtin("array.astype", types.Array, types.DTypeSpec)
@lower_builtin("array.astype", types.Array, types.StringLiteral)
def array_astype(context, builder, sig, args):
arytype = sig.args[0]
ary = make_array(arytype)(context, builder, value=args[0])
Expand Down
1 change: 1 addition & 0 deletions numba/tests/test_array_methods.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,6 +471,7 @@ def check(arr, dtype):
check(arr, np.int32)
check(arr, np.float32)
check(arr, np.complex128)
check(arr, "float32")

# F-contiguous
arr = np.arange(24, dtype=np.int8).reshape((3, 8)).T
Expand Down