Skip to content

gh #7131 Support for astype with literal strings #7132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sklam merged 9 commits into from
Oct 6, 2021
Merged

gh #7131 Support for astype with literal strings #7132

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7abe006
gh #7131 support for astype with literal strings
Jun 21, 2021
7e86ad9
numba/core/types/functions.py
Jul 9, 2021
1646701
updated arraydecl to throw require literal value
Jul 9, 2021
a8e24a9
reverted function changes
Jul 9, 2021
1551c2a
fixed import issue
Aug 3, 2021
82062a8
Added a test that unicode value must be a string literal
Sep 9, 2021
2c8fa0a
Made Stuart's changes
Oct 5, 2021
f7665e4
fixed typo
Oct 5, 2021
97a54df
Update numba/core/typing/arraydecl.py
njriasan Oct 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
updated arraydecl to throw require literal value
  • Loading branch information
Nicholas J Riasanovsky
Nicholas J Riasanovsky committed Jul 9, 2021
commit 16467012d339fecb281fd8b7e60b6be66590a030
3 changes: 3 additions & 0 deletions numba/core/typing/arraydecl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,9 +445,12 @@ def resolve_view(self, ary, args, kws):

@bound_function("array.astype")
def resolve_astype(self, ary, args, kws):
from numba.core.errors import RequireLiteralValue
Comment thread
stuartarchibald marked this conversation as resolved.
Resolved
from .npydecl import parse_dtype
assert not kws
dtype, = args
if dtype == types.unicode_type:

@stuartarchibald stuartarchibald Oct 5, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if dtype == types.unicode_type:
if isinstance(dtype, types.UnicodeType):

raise RequireLiteralValue("array.astype if dtype is a string it must be constant")
Comment thread
stuartarchibald marked this conversation as resolved.
Resolved

@stuartarchibald stuartarchibald Oct 5, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line needs wrapping to 80 chars.

dtype = parse_dtype(dtype)
if dtype is None:
return
Expand Down