Skip to content

Add ndarray allocator classmethod - #7061

Merged
sklam merged 34 commits into
numba:masterfrom
sklam:enh/arrayallocapi
Jun 25, 2021
Merged

Add ndarray allocator classmethod#7061
sklam merged 34 commits into
numba:masterfrom
sklam:enh/arrayallocapi

Conversation

@sklam

@sklam sklam commented May 26, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

as titled

@sklam sklam mentioned this pull request Jun 2, 2021
Closed
stuartarchibald and others added 16 commits June 7, 2021 12:11
@stuartarchibald
Convert operator module functions to overloads.
b683418 
As title.
@stuartarchibald
Fix Black-Scholes test
81ed617
@stuartarchibald
Fix test_array_exprs
2b31732
@stuartarchibald
Flake8
64ca8bc
@stuartarchibald
Fix error handling test
7ddd4d5
@stuartarchibald
Fix debug test
37530ba
@stuartarchibald
Fix up cache test
2cb8766
@stuartarchibald
Remove compile_isolated from svml tests
2c0582c
@sklam @stuartarchibald
Fix test_debug in 32-bit platforms
6b8c62e
@sklam @stuartarchibald
Fix fastmath propagation in SVML.
4188fe5 
There's still remaining problem with compile_internal that is not considering the flags.
@sklam @stuartarchibald
Run SVML tests in isolated processes
b1b4fe3
@sklam @stuartarchibald
Add inheriting behavior for error_model
a5e7c43
@sklam @stuartarchibald
Avoid compile_isolated in looplifting tests
49f1dd8
@sklam
Revert "Convert operator module functions to overloads."
4024a9a
@sklam
Merge branch 'pr/7058' with revert of 0e323f5 into enh/arrayallocapi
57ebd93
@sklam
Revert patches specific to overload operators
30b4eab 
- Revert disabling of fastmath binop pass
- Revert "Fix debug test"
- Revert "Fix test_debug in 32-bit platforms"
@sklam
sklam marked this pull request as ready for review June 8, 2021 23:22
@sklam
sklam requested review from esc and stuartarchibald as code owners June 8, 2021 23:22
@stuartarchibald stuartarchibald added this to the Numba 0.54 RC milestone Jun 16, 2021
@sklam sklam mentioned this pull request Jun 17, 2021
Merged
@sklam

sklam commented Jun 24, 2021

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

azure-pipelines Bot commented Jun 24, 2021

Copy link
Copy Markdown
Contributor
Azure Pipelines successfully started running 1 pipeline(s).

@sklam

sklam commented Jun 24, 2021

Copy link
Copy Markdown
Member Author

@stuartarchibald, this is ready for another look

@sklam

sklam commented Jun 24, 2021

Copy link
Copy Markdown
Member Author

CI actually passed, but the UI is stuck

@stuartarchibald

stuartarchibald commented Jun 25, 2021

Copy link
Copy Markdown
Contributor

/AzurePipelines run

@azure-pipelines

azure-pipelines Bot commented Jun 25, 2021

Copy link
Copy Markdown
Contributor
Azure Pipelines successfully started running 1 pipeline(s).

stuartarchibald
stuartarchibald reviewed Jun 25, 2021
View reviewed changes

@stuartarchibald stuartarchibald left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. I've given the patches that aren't mine a review. In general this looks good, there's a bit of refactoring to do and what I think is a bit of an issue with kwarg handling that needs looking at, however, neither of things things are blockers for merging. The rest of the comments are relatively minor things. Thanks again!

Comment thread numba/np/arrayobj.py Outdated
Comment thread numba/np/arrayobj.py Outdated
Comment thread numba/np/ufunc/ufuncbuilder.py
Comment thread numba/tests/test_svml.py Outdated
Comment thread numba/core/target_extension.py Outdated
Comment thread numba/tests/test_svml.py Outdated
Comment thread numba/tests/test_target_extension.py Outdated
Comment thread numba/tests/test_target_extension.py Outdated
Comment thread numba/tests/test_target_extension.py Outdated
Comment thread numba/tests/test_target_extension.py
@stuartarchibald stuartarchibald added 4 - Waiting on author Waiting for author to respond to review Effort - long Long size effort needed and removed 3 - Ready for Review labels Jun 25, 2021
sklam and others added 3 commits June 25, 2021 11:07
@sklam @stuartarchibald
Apply suggestions from code review
344c5b3 
Co-authored-by: stuartarchibald <stuartarchibald@users.noreply.github.com>
@sklam
Remove dead code
179767a
@sklam
Add timeout to avoid test hanging
a5c48e6
This was referenced Jun 25, 2021
Closed
Closed
@sklam sklam added 4 - Waiting on reviewer Waiting for reviewer to respond to author and removed 4 - Waiting on author Waiting for author to respond to review labels Jun 25, 2021
@sklam

sklam commented Jun 25, 2021

Copy link
Copy Markdown
Member Author

Thanks for the review. All comments should be addressed now.

stuartarchibald
stuartarchibald approved these changes Jun 25, 2021
View reviewed changes

@stuartarchibald stuartarchibald left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch and fixes.

@stuartarchibald stuartarchibald added 4 - Waiting on CI Review etc done, waiting for CI to finish 5 - Ready to merge Review and testing done, is ready to merge and removed 4 - Waiting on reviewer Waiting for reviewer to respond to author 4 - Waiting on CI Review etc done, waiting for CI to finish labels Jun 25, 2021
@sklam
sklam merged commit 26192df into numba:master Jun 25, 2021
@sklam
sklam deleted the enh/arrayallocapi branch June 25, 2021 18:55
@eric-wieser

eric-wieser commented Sep 2, 2021

Copy link
Copy Markdown
Contributor

This unfortunately broke the version of #5886 vendored by clifford, but it shouldn't be too hard a fix.

@eric-wieser eric-wieser mentioned this pull request Sep 2, 2021
Merged
@stuartarchibald

stuartarchibald commented Sep 6, 2021

Copy link
Copy Markdown
Contributor

@eric-wieser thanks for the note, apologies for breaking it, guess it's using some internals that moved? Maybe someone from https://github.com/pygae/clifford/ could subscribe to the RC_Testers group (described here https://numba.discourse.group/t/numba-0-54-0-rc3/835/2) so as to pick up pings about RCs to test when they are available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartarchibald stuartarchibald stuartarchibald approved these changes
@esc esc Awaiting requested review from esc

Assignees

No one assigned

Labels

5 - Ready to merge Review and testing done, is ready to merge Effort - long Long size effort needed highpriority

Projects

None yet

Milestone

Numba 0.54 RC

Development

Successfully merging this pull request may close these issues.

3 participants

@sklam @stuartarchibald @eric-wieser