Skip to content

test: move more inspector sequential tests to parallel #47412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 4 commits into from
Closed

test: move more inspector sequential tests to parallel #47412

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6224372
test: use random port in NodeInstance.startViaSignal()
joyeecheung Apr 4, 2023
2855bca
test: use random port in test-inspector-debug-brk-flag
joyeecheung Apr 4, 2023
431ae1f
test: use random port in test-inspector-enabled
joyeecheung Apr 4, 2023
db0096c
test: move more inspector sequential tests to parallel
joyeecheung Apr 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: use random port in NodeInstance.startViaSignal() 
Which makes it possible to run the tests that use this in parallel.
  • Loading branch information
@joyeecheung
joyeecheung committed Apr 4, 2023
commit 6224372a359e241b7e465bd15be5ddc3ef789a3b
2 changes: 1 addition & 1 deletion test/common/inspector-helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ class NodeInstance extends EventEmitter {

static async startViaSignal(scriptContents) {
const instance = new NodeInstance(
['--expose-internals'],
['--expose-internals', '--inspect-port=0'],
`${scriptContents}\nprocess._rawDebug('started');`, undefined);
const msg = 'Timed out waiting for process to start';
while (await fires(instance.nextStderrString(), msg, TIMEOUT) !== 'started');
Expand Down