Skip to content

test: move more inspector sequential tests to parallel #47412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 4 commits into from
Closed

test: move more inspector sequential tests to parallel #47412

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6224372
test: use random port in NodeInstance.startViaSignal()
joyeecheung Apr 4, 2023
2855bca
test: use random port in test-inspector-debug-brk-flag
joyeecheung Apr 4, 2023
431ae1f
test: use random port in test-inspector-enabled
joyeecheung Apr 4, 2023
db0096c
test: move more inspector sequential tests to parallel
joyeecheung Apr 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: use random port in test-inspector-enabled 
Which makes it possible to run it in parallel.
  • Loading branch information
@joyeecheung
joyeecheung committed Apr 4, 2023
commit 431ae1fc9a8a185ce6e1e1d8c0324559971f443d
2 changes: 1 addition & 1 deletion test/sequential/test-inspector-enabled.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ assert(
'inspector.isEnabled() should be false after _debugEnd()');
`;

const args = ['--inspect', '-e', script];
const args = ['--inspect=0', '-e', script];
const child = spawn(process.execPath, args, {
stdio: 'inherit',
env: { ...process.env, NODE_V8_COVERAGE: '' }
Expand Down