Skip to content

module: deprecate trailing slash pattern mappings #40039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guybedford wants to merge 5 commits into from
Closed

module: deprecate trailing slash pattern mappings #40039

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
819aa31
module: deprecate trailing slash pattern mappings
guybedford Sep 8, 2021
266a0a6
fixup: exports deprecation check tests
guybedford Sep 8, 2021
5129ba6
fixup: make documentation-only deprecation
guybedford Sep 8, 2021
8a0989a
fixup: deprecation docs
guybedford Sep 8, 2021
2dc4199
fixup: log
guybedford Sep 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: make documentation-only deprecation 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
@guybedford @aduh95
guybedford and aduh95 committed Sep 8, 2021
commit 5129ba6e924721339d100e8c0ebeb4fdfe6a3f66
6 changes: 6 additions & 0 deletions doc/api/deprecations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2815,6 +2815,12 @@ The `'hash'` and `'mgf1Hash'` options are replaced with `'hashAlgorithm'`
and `'mgf1HashAlgorithm'`.

### DEP0155: Trailing slashes in pattern specifier resolutions
Comment thread
guybedford marked this conversation as resolved.
Resolved
<!-- YAML
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/40039
description: Documentation-only.
Comment thread
guybedford marked this conversation as resolved.
Resolved
-->

Type: Runtime
Comment thread
guybedford marked this conversation as resolved.
Resolved
Comment thread
guybedford marked this conversation as resolved.
Resolved

Expand Down
2 changes: 2 additions & 0 deletions lib/internal/modules/esm/resolve.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ const { sep, relative, resolve } = require('path');
const preserveSymlinks = getOptionValue('--preserve-symlinks');
const preserveSymlinksMain = getOptionValue('--preserve-symlinks-main');
const typeFlag = getOptionValue('--input-type');
const pendingDeprecation = getOptionValue('--pending-deprecation');
const { URL, pathToFileURL, fileURLToPath } = require('internal/url');
const {
ERR_INPUT_TYPE_NOT_ALLOWED,
Expand Down Expand Up @@ -98,6 +99,7 @@ function emitFolderMapDeprecation(match, pjsonUrl, isExports, base) {
}

function emitTrailingSlashPatternDeprecation(match, pjsonUrl, isExports, base) {
if (!pendingDeprecation) return;
const pjsonPath = fileURLToPath(pjsonUrl);
if (emittedPackageWarnings.has(pjsonPath + '|' + match))
return;
Expand Down
1 change: 1 addition & 0 deletions test/es-module/test-esm-exports-deprecations.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// Flags: --pending-deprecation
import { mustCall } from '../common/index.mjs';
import assert from 'assert';

Expand Down
2 changes: 2 additions & 0 deletions test/es-module/test-esm-local-deprecations.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// Flags: --pending-deprecation

import '../common/index.mjs';
import assert from 'assert';
import fixtures from '../common/fixtures.js';
Expand Down