Skip to content

module: deprecate trailing slash pattern mappings #40039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guybedford wants to merge 5 commits into from
Closed

module: deprecate trailing slash pattern mappings #40039

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
819aa31
module: deprecate trailing slash pattern mappings
guybedford Sep 8, 2021
266a0a6
fixup: exports deprecation check tests
guybedford Sep 8, 2021
5129ba6
fixup: make documentation-only deprecation
guybedford Sep 8, 2021
8a0989a
fixup: deprecation docs
guybedford Sep 8, 2021
2dc4199
fixup: log
guybedford Sep 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: exports deprecation check tests
  • Loading branch information
@guybedford
guybedford committed Sep 8, 2021
commit 266a0a6d9ccaa9fe2e1d8f72c7957662117169f8
4 changes: 4 additions & 0 deletions test/es-module/test-esm-exports-deprecations.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,17 @@ let curWarning = 0;
const expectedWarnings = [
'"./sub/"',
'"./fallbackdir/"',
'"./trailing-pattern-slash/"',
'"./subpath/"',
'"./subpath/dir1/"',
'"./subpath/dir2/"',
'no_exports',
'default_index',
];

process.addListener('warning', mustCall((warning) => {
assert(warning.stack.includes(expectedWarnings[curWarning++]), warning.stack);
console.log(expectedWarnings[curWarning - 1] + ' passed');
Comment thread
guybedford marked this conversation as resolved.
Resolved
}, expectedWarnings.length));

await import('./test-esm-exports.mjs');