Skip to content

[v15.x] deps: update V8 to 8.7 #36182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 24 commits into from
Closed

[v15.x] deps: update V8 to 8.7 #36182

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
6327cfe
deps: update V8 to 8.7.220
targos Nov 19, 2020
500ead2
build: reset embedder string to "-node.0"
targos Nov 19, 2020
ad8eed3
deps: V8: un-cherry-pick bd019bd
refack Mar 27, 2019
6da0120
deps: patch V8 to run on older XCode versions
ryzokuken Sep 14, 2019
3fac798
deps: V8: patch register-arm64.h
refack May 22, 2019
a79d681
deps: V8: forward declaration of `Rtl*FunctionTable`
refack May 22, 2019
60fb216
deps: make v8.h compatible with VS2015
joaocgreis Nov 1, 2019
dc721ee
deps: V8: silence irrelevant warnings
targos Mar 27, 2019
b4e1287
deps: patch V8 to run on Xcode 8
mmarchini Mar 10, 2020
cfd934f
deps: update V8 postmortem metadata script
cjihrig Jul 4, 2020
7f96548
deps: update V8 postmortem metadata script
cjihrig Sep 15, 2020
5e10ebb
deps: fix V8 build issue with inline methods
gengjiawen Oct 14, 2020
ed898f7
deps: V8: cherry-pick d76abfed3512
targos Oct 14, 2020
e262dab
deps: V8: cherry-pick 3176bfd447a9
addaleax Oct 12, 2020
6218c1c
deps: V8: cherry-pick 7b3a27b7ae65
targos Oct 19, 2020
685fbe2
deps: V8: cherry-pick 45e49775f5a3
targos Oct 21, 2020
1772fe1
deps: cherry-pick 9a49b22 from V8 upstream
danbev Nov 3, 2020
f4305dd
deps: V8: cherry-pick 821fb3883a8e
targos Nov 12, 2020
d074cfd
deps: V8: cherry-pick 086eecbd96b6
oleavr Nov 6, 2020
3e15799
deps: V8: cherry-pick 4e077ff0444a
oleavr Nov 6, 2020
de67931
deps: V8: cherry-pick 1d0f426311d4
oleavr Nov 6, 2020
685cb6e
src: fix v8 api deprecation
gengjiawen Sep 15, 2020
b7311fb
tools: update V8 gypfiles for 8.7
targos Sep 11, 2020
ad2fd53
deps: V8: restore compatibility with 8.6
targos Nov 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deps: V8: cherry-pick 7b3a27b7ae65 
Original commit message:

    fix: correct calling convention for Windows on Arm

    Corrects a "Check failed: kFPParamRegisterCount == kParamRegisterCount"
    message when compiling v8_snapshot for Windows on Arm.

    Unlike x64, Windows on Arm's calling convention does not alternate
    between integer and float registers.

    Bug: chromium:1052746
    Change-Id: I4c9cdafcd6e43742b94613f85b2983761cc0891a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2440717
    Commit-Queue: Maya Lekova <mslekova@chromium.org>
    Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: Maya Lekova <mslekova@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70257}

Refs: v8/v8@7b3a27b

PR-URL: #35700
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
  • Loading branch information
@targos
targos committed Nov 19, 2020
commit 6218c1c73459a2eca989650c28caad223dd9e351
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.12',
'v8_embedder_string': '-node.13',

##### V8 defaults for Node.js #####

Expand Down
9 changes: 5 additions & 4 deletions deps/v8/src/compiler/c-linkage.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ namespace {
#endif
} // namespace

#ifdef V8_TARGET_OS_WIN
#if defined(V8_TARGET_OS_WIN) && defined(V8_TARGET_ARCH_X64)
// As defined in
// https://docs.microsoft.com/en-us/cpp/build/x64-calling-convention?view=vs-2019#parameter-passing,
// Windows calling convention doesn't differentiate between GP and FP params
Expand Down Expand Up @@ -176,11 +176,12 @@ void BuildParameterLocations(const MachineSignature* msig,
}
}
}
#else // V8_TARGET_OS_WIN
#else // defined(V8_TARGET_OS_WIN) && defined(V8_TARGET_ARCH_X64)
// As defined in https://www.agner.org/optimize/calling_conventions.pdf,
// Section 7, Linux and Mac place parameters in consecutive registers,
// differentiating between GP and FP params. That's why we maintain two
// separate counters here.
// separate counters here. This also applies to Arm systems following
// the AAPCS and Windows on Arm.
void BuildParameterLocations(const MachineSignature* msig,
size_t kFPParamRegisterCount,
size_t kParamRegisterCount,
Expand Down Expand Up @@ -216,7 +217,7 @@ void BuildParameterLocations(const MachineSignature* msig,
}
}
}
#endif // V8_TARGET_OS_WIN
#endif // defined(V8_TARGET_OS_WIN) && defined(V8_TARGET_ARCH_X64)

// General code uses the above configuration data.
CallDescriptor* Linkage::GetSimplifiedCDescriptor(Zone* zone,
Expand Down