Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
6327cfe
deps: update V8 to 8.7.220
targos Nov 19, 2020
500ead2
build: reset embedder string to "-node.0"
targos Nov 19, 2020
ad8eed3
deps: V8: un-cherry-pick bd019bd
refack Mar 27, 2019
6da0120
deps: patch V8 to run on older XCode versions
ryzokuken Sep 14, 2019
3fac798
deps: V8: patch register-arm64.h
refack May 22, 2019
a79d681
deps: V8: forward declaration of `Rtl*FunctionTable`
refack May 22, 2019
60fb216
deps: make v8.h compatible with VS2015
joaocgreis Nov 1, 2019
dc721ee
deps: V8: silence irrelevant warnings
targos Mar 27, 2019
b4e1287
deps: patch V8 to run on Xcode 8
mmarchini Mar 10, 2020
cfd934f
deps: update V8 postmortem metadata script
cjihrig Jul 4, 2020
7f96548
deps: update V8 postmortem metadata script
cjihrig Sep 15, 2020
5e10ebb
deps: fix V8 build issue with inline methods
gengjiawen Oct 14, 2020
ed898f7
deps: V8: cherry-pick d76abfed3512
targos Oct 14, 2020
e262dab
deps: V8: cherry-pick 3176bfd447a9
addaleax Oct 12, 2020
6218c1c
deps: V8: cherry-pick 7b3a27b7ae65
targos Oct 19, 2020
685fbe2
deps: V8: cherry-pick 45e49775f5a3
targos Oct 21, 2020
1772fe1
deps: cherry-pick 9a49b22 from V8 upstream
danbev Nov 3, 2020
f4305dd
deps: V8: cherry-pick 821fb3883a8e
targos Nov 12, 2020
d074cfd
deps: V8: cherry-pick 086eecbd96b6
oleavr Nov 6, 2020
3e15799
deps: V8: cherry-pick 4e077ff0444a
oleavr Nov 6, 2020
de67931
deps: V8: cherry-pick 1d0f426311d4
oleavr Nov 6, 2020
685cb6e
src: fix v8 api deprecation
gengjiawen Sep 15, 2020
b7311fb
tools: update V8 gypfiles for 8.7
targos Sep 11, 2020
ad2fd53
deps: V8: restore compatibility with 8.6
targos Nov 19, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deps: cherry-pick 9a49b22 from V8 upstream
Original commit message:
  Fix alloc/dealloc size mismatch for v8::BackingStore

  On newer compilers the {operator delete} with explicit {size_t}
  argument would be instantiated for {v8::BackingStore} and used
  in the destructor of {std::unique_ptr<v8::BackingStore>}. The {size_t}
  argument is wrong though, since the pointer actually points
  to a {v8::internal::BackingStore} object.
  The solution is to explicitly provide a {operator delete}, preventing
  an implicitly generated {size_t} operator.

  Bug:v8:11081

  Change-Id: Iee0aa47a67f0e41000bea628942f7e3d70198b83
  Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2506712
  Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
  Reviewed-by: Camillo Bruni <cbruni@chromium.org>
  Cr-Commit-Position: refs/heads/master@{#70916}

PR-URL: #35939
Fixes: #35669
Refs: v8/v8@9a49b22
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
  • Loading branch information
danbev authored and targos committed Nov 19, 2020
commit 1772fe1160157a3a71f94a872b63be695d452903
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.14',
'v8_embedder_string': '-node.15',

##### V8 defaults for Node.js #####

Expand Down
7 changes: 7 additions & 0 deletions deps/v8/include/v8.h
Original file line number Diff line number Diff line change
Expand Up @@ -5054,6 +5054,13 @@ class V8_EXPORT BackingStore : public v8::internal::BackingStoreBase {
*/
bool IsShared() const;

/**
* Prevent implicit instantiation of operator delete with size_t argument.
* The size_t argument would be incorrect because ptr points to the
* internal BackingStore object.
*/
void operator delete(void* ptr) { ::operator delete(ptr); }

/**
* Wrapper around ArrayBuffer::Allocator::Reallocate that preserves IsShared.
* Assumes that the backing_store was allocated by the ArrayBuffer allocator
Expand Down