Skip to content

test: introduce SetUpTestCase/TearDownTestCase #18558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danbev wants to merge 4 commits into from
Closed

test: introduce SetUpTestCase/TearDownTestCase #18558

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5f364ee
test: introduce SetUpTestCase/TearDownTestCase
danbev Feb 3, 2018
df3800d
test: remove NodeTestFixture from Env constructor
danbev Feb 3, 2018
fdfd826
squash: set number of theads to 4
danbev Feb 4, 2018
ad04fb9
squash: add check for null isolate
danbev Feb 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash: set number of theads to 4
  • Loading branch information
@danbev
danbev committed Feb 5, 2018
commit fdfd8262fe7eb4b5c56ff75f2d10cee36dcbb6d8
2 changes: 1 addition & 1 deletion test/cctest/node_test_fixture.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ class NodeTestFixture : public ::testing::Test {
v8::Isolate* isolate_;

static void SetUpTestCase() {
platform.reset(new node::NodePlatform(8, nullptr));
platform.reset(new node::NodePlatform(4, nullptr));
tracing_controller.reset(new v8::TracingController());
allocator.reset(v8::ArrayBuffer::Allocator::NewDefaultAllocator());
params.array_buffer_allocator = allocator.get();
Expand Down