Skip to content

test: introduce SetUpTestCase/TearDownTestCase #18558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danbev wants to merge 4 commits into from
Closed

test: introduce SetUpTestCase/TearDownTestCase #18558

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5f364ee
test: introduce SetUpTestCase/TearDownTestCase
danbev Feb 3, 2018
df3800d
test: remove NodeTestFixture from Env constructor
danbev Feb 3, 2018
fdfd826
squash: set number of theads to 4
danbev Feb 4, 2018
ad04fb9
squash: add check for null isolate
danbev Feb 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
squash: add check for null isolate
  • Loading branch information
@danbev
danbev committed Feb 5, 2018
commit ad04fb96890c1972d802c4b0f291871bdb806c0c
1 change: 1 addition & 0 deletions test/cctest/node_test_fixture.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ class NodeTestFixture : public ::testing::Test {

virtual void SetUp() {
isolate_ = v8::Isolate::New(params);

@bnoordhuis bnoordhuis Feb 4, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a CHECK_NE(isolate_, nullptr)?

@danbev danbev Feb 4, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing, I'll add the check. Thanks

CHECK_NE(isolate_, nullptr);
}

virtual void TearDown() {
Expand Down