Skip to content

Ensure Language Server can start without ICU - #5196

Merged
Don Jayamanne (DonJayamanne) merged 2 commits into
microsoft:masterfrom
DonJayamanne:issue5043
Apr 15, 2019
Merged

Don Jayamanne (DonJayamanne) merged 2 commits into
microsoft:masterfrom
DonJayamanne:issue5043

Conversation

@DonJayamanne

Copy link
Copy Markdown

For #5043

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • [n/a] Has sufficient logging.
  • [n/a] Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [n/a] The wiki is updated with any design decisions/details.

@karrtikr Kartik Raj (karrtikr) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DonJayamanne
Don Jayamanne (DonJayamanne) merged commit 075d574 into microsoft:master Apr 15, 2019
@DonJayamanne
Don Jayamanne (DonJayamanne) deleted the issue5043 branch May 24, 2019 20:26
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants