Repository navigation
Fixes to shell detection - #5923
Merged
Don Jayamanne (DonJayamanne) merged 2 commits intoJun 5, 2019
Merged
Don Jayamanne (DonJayamanne) merged 2 commits into
Don Jayamanne (DonJayamanne) merged 2 commits into
Conversation
Eric Snow (ericsnowcurrently)
self-requested a review
June 5, 2019 21:19
Eric Snow (ericsnowcurrently)
approved these changes
Jun 5, 2019
Eric Snow (ericsnowcurrently)
left a comment
Eric Snow (ericsnowcurrently)
left a comment
There was a problem hiding this comment.
LGTM (assuming you didn't break anything with the refactoring :) )
Also, it would have been much easier to review if the refactoring had been done in a separate PR. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #5916
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)