Skip to content

Fix getting display name and version when using windows registry #1697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Don Jayamanne (DonJayamanne) merged 7 commits into from
May 21, 2018
Merged

Fix getting display name and version when using windows registry #1697

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7bf386a
:bug: fix getting display name and version when using windows registry
DonJayamanne May 16, 2018
db99e17
Git hook for tests
DonJayamanne May 16, 2018
2704c0d
:memo: add news entry
DonJayamanne May 16, 2018
d557f97
Some more unit tests
DonJayamanne May 17, 2018
6d52131
Mock VS Code only inside the test runner
DonJayamanne May 19, 2018
9233d0d
Singleton mocks for vscode namespcaes
DonJayamanne May 21, 2018
9c8efa7
Fix test
DonJayamanne May 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Singleton mocks for vscode namespcaes
  • Loading branch information
@DonJayamanne
DonJayamanne committed May 21, 2018
commit 9233d0db20ce0065d8125e634be4bb4c711912c5
35 changes: 31 additions & 4 deletions src/test/vscode-mock.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,24 @@ const Module = require('module');
type VSCode = typeof vscode;

const mockedVSCode: Partial<VSCode> = {};

const mockedVSCodeNamespaces: { [P in keyof VSCode]?: TypeMoq.IMock<VSCode[P]> } = {};
const originalLoad = Module._load;

generateMock('workspace');
generateMock('window');
generateMock('commands');
generateMock('languages');
generateMock('env');
generateMock('debug');
generateMock('extensions');
generateMock('scm');

function generateMock<K extends keyof VSCode>(name: K): void {
const mockedObj = TypeMoq.Mock.ofType<VSCode[K]>();
mockedVSCode[name] = mockedObj.object;
mockedVSCodeNamespaces[name] = mockedObj as any;
}

export function initialize() {
Module._load = function (request, parent) {
if (request === 'vscode') {
Expand All @@ -24,10 +39,22 @@ export function initialize() {
};
}

/**
* Gets the mocked VS Code namespaces/classes.
* For VS Code namespaces, always return pre-mocked objects, else create a new mock object.
* @export
* @template K
* @param {K} name
* @returns {TypeMoq.IMock<VSCode[K]>}
*/
export function mock<K extends keyof VSCode>(name: K): TypeMoq.IMock<VSCode[K]> {
const mockedObj = TypeMoq.Mock.ofType<VSCode[K]>();
mockedVSCode[name] = mockedObj.object;
return mockedObj;
if (mockedVSCodeNamespaces[name] === undefined) {
return TypeMoq.Mock.ofType<VSCode[K]>();
}
// When re-using, always reset (other tests could have used this same instance).
const mockObj = mockedVSCodeNamespaces[name]!;
mockObj.reset();
return mockObj as any as TypeMoq.IMock<VSCode[K]>;
}

// This is one of the very few classes that we need in our unit tests.
Expand Down