Skip to content

Fix getting display name and version when using windows registry #1697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Don Jayamanne (DonJayamanne) merged 7 commits into from
May 21, 2018
Merged

Fix getting display name and version when using windows registry #1697

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7bf386a
:bug: fix getting display name and version when using windows registry
DonJayamanne May 16, 2018
db99e17
Git hook for tests
DonJayamanne May 16, 2018
2704c0d
:memo: add news entry
DonJayamanne May 16, 2018
d557f97
Some more unit tests
DonJayamanne May 17, 2018
6d52131
Mock VS Code only inside the test runner
DonJayamanne May 19, 2018
9233d0d
Singleton mocks for vscode namespcaes
DonJayamanne May 21, 2018
9c8efa7
Fix test
DonJayamanne May 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Mock VS Code only inside the test runner
  • Loading branch information
@DonJayamanne
DonJayamanne committed May 21, 2018
commit 6d521317aac9c5d24e53e62cda7fc596812d4018
4 changes: 3 additions & 1 deletion src/test/unittests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,15 @@
if ((Reflect as any).metadata === undefined) {
require('reflect-metadata');
}
require('./vscode-mock');
import * as glob from 'glob';
import * as Mocha from 'mocha';
import * as path from 'path';
import { MochaSetupOptions } from 'vscode/lib/testrunner';
import * as vscodeMoscks from './vscode-mock';

export function runTests(testOptions?: { grep?: string; timeout?: number }) {
vscodeMoscks.initialize();

const grep: string | undefined = testOptions ? testOptions.grep : undefined;
const timeout: number | undefined = testOptions ? testOptions.timeout : undefined;
const options: MochaSetupOptions = {
Expand Down
15 changes: 9 additions & 6 deletions src/test/vscode-mock.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,15 @@ type VSCode = typeof vscode;
const mockedVSCode: Partial<VSCode> = {};

const originalLoad = Module._load;
Module._load = function (request, parent) {
if (request === 'vscode') {
return mockedVSCode;
}
return originalLoad.apply(this, arguments);
};

export function initialize() {
Module._load = function (request, parent) {
if (request === 'vscode') {
return mockedVSCode;
}
return originalLoad.apply(this, arguments);
};
}

export function mock<K extends keyof VSCode>(name: K): TypeMoq.IMock<VSCode[K]> {
const mockedObj = TypeMoq.Mock.ofType<VSCode[K]>();
Expand Down