Skip to content

Made exporting notebooks cancellable #12863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tim Ruscica (techwithtim) merged 7 commits into from
Jul 10, 2020
Merged

Made exporting notebooks cancellable #12863

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cab6f77
made export cancellable
techwithtim Jul 9, 2020
07a9e47
some small fixes
techwithtim Jul 10, 2020
a2d70d7
removed monaco editor import
techwithtim Jul 10, 2020
89c1b75
changed deleting method
techwithtim Jul 10, 2020
b8e298d
made export to temp file first
techwithtim Jul 10, 2020
5795b9f
removed unused action
techwithtim Jul 10, 2020
1656926
removed unused types
techwithtim Jul 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
removed unused types
  • Loading branch information
@techwithtim
techwithtim committed Jul 10, 2020
commit 16569264f683af9ccc3c80ace3b7b6131fc6fd69
3 changes: 1 addition & 2 deletions src/client/datascience/progress/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,5 @@ export enum ReportableAction {
InstallingMissingDependencies = 'InstallingMissingDependencies',
ExportNotebookToPython = 'ExportNotebookToPython',
PerformingExport = 'PerformingExport',
ConvertingToPDF = 'ConvertingToPDF',
CopyingFile = 'CopyingFile'
ConvertingToPDF = 'ConvertingToPDF'
}