Repository navigation
Made exporting notebooks cancellable - #12863
Merged
Merged
Conversation
Tim Ruscica (techwithtim)
requested review from
Don Jayamanne (DonJayamanne) and
Rich Chiodo (rchiodo)
and removed request for
Don Jayamanne (DonJayamanne)
July 10, 2020 15:41
Don Jayamanne (DonJayamanne)
requested changes
Jul 10, 2020
Tim Ruscica (techwithtim)
marked this pull request as ready for review
July 10, 2020 16:06
Don Jayamanne (DonJayamanne)
approved these changes
Jul 10, 2020
Tim Ruscica (techwithtim)
force-pushed
the
changes
branch
from
July 10, 2020 18:46
348ed5a to
b8e298d
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Don Jayamanne (DonJayamanne)
approved these changes
Jul 10, 2020
Don Jayamanne (DonJayamanne)
pushed a commit
that referenced
this pull request
Jul 10, 2020
* made export cancellable * some small fixes * removed monaco editor import * changed deleting method * made export to temp file first * removed unused action * removed unused types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the export process cancellable. You can cancel by simply hitting the "cancel" button on the shown progress reporter.
Note: if the user cancels the export when the exported file has already been created than that file will be automatically deleted.
Has sufficient logging.Has telemetry for enhancements.Test plan is updated as appropriate.package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).The wiki is updated with any design decisions/details.