Skip to content

Rchiodo/kernel telemetry #10115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rich Chiodo (rchiodo) merged 14 commits into from
Feb 13, 2020
Merged

Rchiodo/kernel telemetry #10115

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f999ec4
Add duration to select local/remote kernel
rchiodo Feb 12, 2020
8545aee
Add notebook language telemetry
rchiodo Feb 13, 2020
8c04a7a
Add news entries
rchiodo Feb 13, 2020
ec0e889
#9883 telemetry
rchiodo Feb 13, 2020
e411a4e
News entry
rchiodo Feb 13, 2020
15f2e50
Another spot for kernel spec failure
rchiodo Feb 13, 2020
55b75dd
Add telemetry on product install
rchiodo Feb 13, 2020
55cd158
Fix install telemetry
rchiodo Feb 13, 2020
bef29b3
Merge remote-tracking branch 'origin/master' into rchiodo/kernel_tele…
rchiodo Feb 13, 2020
a8cae87
Undo launch.json change
rchiodo Feb 13, 2020
89f30c5
Handle other cases
rchiodo Feb 13, 2020
b53b6a7
Better way to handle case
rchiodo Feb 13, 2020
2f2462d
Wrong event for jupyter install
rchiodo Feb 13, 2020
73c206c
Fix unit tests
rchiodo Feb 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add telemetry on product install
  • Loading branch information
@rchiodo
rchiodo committed Feb 13, 2020
commit 55b75ddf318e299b37499de54ba7c89ca225796d
19 changes: 18 additions & 1 deletion src/client/common/installer/productInstaller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import * as os from 'os';
import { CancellationToken, OutputChannel, Uri } from 'vscode';
import '../../common/extensions';
import * as localize from '../../common/utils/localize';
import { Telemetry } from '../../datascience/constants';
import { IInterpreterService } from '../../interpreter/contracts';
import { IServiceContainer } from '../../ioc/types';
import { LinterId } from '../../linters/types';
Expand All @@ -27,6 +28,7 @@ import {
ProductType
} from '../types';
import { isResource } from '../utils/misc';
import { StopWatch } from '../utils/stopWatch';
import { ProductNames } from './productNames';
import { IInstallationChannelManager, InterpreterUri, IProductPathService, IProductService } from './types';

Expand Down Expand Up @@ -355,7 +357,22 @@ export class DataScienceInstaller extends BaseInstaller {
'Yes',
'No'
);
return item === 'Yes' ? this.install(product, resource, cancel) : InstallerResponse.Ignore;
if (item === 'Yes') {
const stopWatch = new StopWatch();
try {
const response = await this.install(product, resource, cancel);
const event =
product === Product.jupyter ? Telemetry.UserInstalledJupyter : Telemetry.UserInstalledModule;
sendTelemetryEvent(event, stopWatch.elapsedTime, { product: product.toString() });
return response;
} catch (e) {
if (product === Product.jupyter) {
sendTelemetryEvent(Telemetry.JupyterInstallFailed);

@IanMatthewHuff Ian Huff (IanMatthewHuff) Feb 13, 2020 •
edited by rchiodo
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not relevant in particular to our team. But might be worthwhile just for the extension in general to log telemetry on UserModuleInstallFailed. #WontFix

@rchiodo Rich Chiodo (rchiodo) Feb 13, 2020

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dan/Savannah can ask for this if they want it I think. Not sure we should add telemetry unless they want it.

In reply to: 379120268 [](ancestors = 379120268)

}
throw e;
}
}
return InstallerResponse.Ignore;
}
}

Expand Down