Skip to content

Rchiodo/kernel telemetry #10115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rich Chiodo (rchiodo) merged 14 commits into from
Feb 13, 2020
Merged

Rchiodo/kernel telemetry #10115

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f999ec4
Add duration to select local/remote kernel
rchiodo Feb 12, 2020
8545aee
Add notebook language telemetry
rchiodo Feb 13, 2020
8c04a7a
Add news entries
rchiodo Feb 13, 2020
ec0e889
#9883 telemetry
rchiodo Feb 13, 2020
e411a4e
News entry
rchiodo Feb 13, 2020
15f2e50
Another spot for kernel spec failure
rchiodo Feb 13, 2020
55b75dd
Add telemetry on product install
rchiodo Feb 13, 2020
55cd158
Fix install telemetry
rchiodo Feb 13, 2020
bef29b3
Merge remote-tracking branch 'origin/master' into rchiodo/kernel_tele…
rchiodo Feb 13, 2020
a8cae87
Undo launch.json change
rchiodo Feb 13, 2020
89f30c5
Handle other cases
rchiodo Feb 13, 2020
b53b6a7
Better way to handle case
rchiodo Feb 13, 2020
2f2462d
Wrong event for jupyter install
rchiodo Feb 13, 2020
73c206c
Fix unit tests
rchiodo Feb 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Wrong event for jupyter install
  • Loading branch information
@rchiodo
rchiodo committed Feb 13, 2020
commit 2f2462d891865810b6b6a5ec5858dad173180985
2 changes: 1 addition & 1 deletion src/client/datascience/jupyter/interpreter/jupyterCommandInterpreterDependencyService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export class JupyterCommandInterpreterDependencyService implements IJupyterInter
installers[0]
.installModule(product)
.then(() => {
sendTelemetryEvent(Telemetry.UserInstalledModule, stopWatch.elapsedTime, { product });
sendTelemetryEvent(Telemetry.UserInstalledJupyter, stopWatch.elapsedTime);
})
.catch(e => {
sendTelemetryEvent(Telemetry.JupyterInstallFailed, undefined, { product });
Expand Down