Skip to content

.NET: fix: preserve agent continuation token when wrapped with UseOpenTelemetry #8265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SergeyMenshykh merged 5 commits into from
Oct 12, 2026
Merged

.NET: fix: preserve agent continuation token when wrapped with UseOpenTelemetry #8265

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
04f9a48
.NET: fix: preserve agent continuation token through OpenTelemetryAgent
atty57 Sep 10, 2026
6cf4994
Add Model Id to OpenTelemetryAgent response
atty57 Sep 10, 2026
1367451
Merge branch 'main' into atty57-issue-8243
atty57 Oct 7, 2026
b518918
Merge branch 'main' into atty57-issue-8243
atty57 Oct 9, 2026
516aef2
Carry ModelId through the streaming update wrapper
atty57 Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Carry ModelId through the streaming update wrapper 
The ChatResponseUpdate the agent's update is wrapped in for telemetry dropped
ModelId, so gen_ai.response.model was missing on streaming runs.
  • Loading branch information
@atty57
atty57 committed Oct 9, 2026
commit 516aef2441d7861267ab1ea8f4f43f5f51e22715
1 change: 1 addition & 0 deletions dotnet/src/Microsoft.Agents.AI/OpenTelemetryAgent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,7 @@ private static ChatResponseUpdate ToChatResponseUpdate(AgentResponseUpdate updat
CreatedAt = update.CreatedAt,
FinishReason = update.FinishReason,
MessageId = update.MessageId,
ModelId = (update.RawRepresentation as ChatResponseUpdate)?.ModelId,
RawRepresentation = update,
ResponseId = update.ResponseId,
Role = update.Role,
Comment thread
SergeyMenshykh marked this conversation as resolved.
Resolved
Expand Down
38 changes: 38 additions & 0 deletions dotnet/tests/Microsoft.Agents.AI.UnitTests/OpenTelemetryAgentTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1033,6 +1033,44 @@ public async Task RunStreamingAsync_WrappingChatClientAgent_PreservesAgentContin
}
#pragma warning restore MEAI001

[Fact]
public async Task RunStreamingAsync_ReportsResponseModelFromInnerUpdateAsync()
{
// Arrange
// The telemetry chat client reads the response model off the ChatResponseUpdate the agent's update is
// wrapped in, so ModelId has to be carried over from the inner update's raw representation.
var sourceName = Guid.NewGuid().ToString();
var activities = new ConcurrentActivityList();
using var tracerProvider = OpenTelemetry.Sdk.CreateTracerProviderBuilder()
.AddSource(sourceName)
.AddInMemoryExporter(activities)
.Build();

var innerAgent = new TestAIAgent { RunStreamingAsyncFunc = CallbackAsync };

async static IAsyncEnumerable<AgentResponseUpdate> CallbackAsync(
IEnumerable<ChatMessage> messages, AgentSession? session, AgentRunOptions? options, [EnumeratorCancellation] CancellationToken cancellationToken)
{
await Task.Yield();
yield return new AgentResponseUpdate(ChatRole.Assistant, "ok")
{
RawRepresentation = new ChatResponseUpdate { ModelId = "innermodel" },
};
}

using var agent = new OpenTelemetryAgent(innerAgent, sourceName);

// Act
await foreach (var update in agent.RunStreamingAsync("hi"))
{
await Task.Yield();
}

// Assert
var activity = Assert.Single(activities);
Assert.Equal("innermodel", activity.GetTagItem("gen_ai.response.model"));
}

[Fact]
public async Task AutoWireChatClient_ChatClientAgentRunOptions_NoUserFactory_PreservesChatOptions_Async()
{
Expand Down
Loading