Repository navigation
.NET: fix: preserve agent continuation token when wrapped with UseOpenTelemetry #8265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
04f9a48
.NET: fix: preserve agent continuation token through OpenTelemetryAgent
atty57 6cf4994
Add Model Id to OpenTelemetryAgent response
atty57 1367451
Merge branch 'main' into atty57-issue-8243
atty57 b518918
Merge branch 'main' into atty57-issue-8243
atty57 516aef2
Carry ModelId through the streaming update wrapper
atty57 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
.NET: fix: preserve agent continuation token through OpenTelemetryAgent
OpenTelemetryAgent routes runs through OpenTelemetryChatClient, so every response makes an AgentResponse -> ChatResponse -> AgentResponse round trip. AsChatResponse/AsChatResponseUpdate return the inner agent's own ChatResponse when that is the response's raw representation, so the round trip dropped agent-level state: for a ChatClientAgent the caller received the provider's raw continuation token instead of the ChatClientAgentContinuationToken, and resuming with it threw. AgentId was lost the same way. Wrap the inner agent's response in a ChatResponse that keeps the response itself as the raw representation, so RunCoreAsync/RunCoreStreamingAsync hand back the original instance unchanged. Fixes #8243
- Loading branch information
commit 04f9a486a1b960ba2e74fff5483d530999c0562b
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.