Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

feat: add support for updateDatabase in Cloud Spanner #914

Merged
rajatbhatta merged 14 commits into from
May 16, 2023
Merged

feat: add support for updateDatabase in Cloud Spanner #914

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e4163d0
feat: drop database protection
aayushimalik Mar 16, 2023
1d64d5d
feat: drop database protection sample and sample test
aayushimalik Mar 21, 2023
ee653cd
Make sample changes follow client lib spec
aayushimalik Apr 4, 2023
167f68b
Reviewer suggested changes.
aayushimalik Apr 12, 2023
b27fd76
Add test for invalid UpdateDatabaseRequest.
aayushimalik Apr 12, 2023
545cd8c
Update field name `drop_protection_enabled` to `enable_drop_protection`.
aayushimalik Apr 13, 2023
430543c
Formatting fix.
aayushimalik Apr 21, 2023
babd236
Update the `reconciling` field when reloading a database.
aayushimalik May 11, 2023
5420284
Merge remote-tracking branch 'googleapi-python-spanner/main' into dro…
aayushimalik May 12, 2023
a700a02
linting fix
rajatbhatta May 16, 2023
effbfbf
Merge branch 'main' into drop-database-protection
rajatbhatta May 16, 2023
8ad7820
Merge branch 'main' into drop-database-protection
rajatbhatta May 16, 2023
23c2014
Merge branch 'googleapis:main' into drop-database-protection-samples
rajatbhatta May 16, 2023
970cb8a
Merge branch 'drop-database-protection-samples' into drop-database-pr…
rajatbhatta May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update the reconciling field when reloading a database.
  • Loading branch information
@aayushimalik
aayushimalik committed May 11, 2023
commit babd236ff2a0db2d3c402377385f7e5fb0ba9d5b
1 change: 1 addition & 0 deletions google/cloud/spanner_v1/database.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,6 +488,7 @@ def reload(self):
self._default_leader = response.default_leader
self._database_dialect = response.database_dialect
self._enable_drop_protection = response.enable_drop_protection
self._reconciling = response.reconciling

def update_ddl(self, ddl_statements, operation_id=""):
"""Update DDL for this database.
Expand Down
4 changes: 4 additions & 0 deletions tests/unit/test_database.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -747,6 +747,8 @@ def test_reload_success(self):
encryption_config=encryption_config,
encryption_info=encryption_info,
default_leader=default_leader,
reconciling=True,
enable_drop_protection=True
)
api.get_database.return_value = db_pb
instance = _Instance(self.INSTANCE_NAME, client=client)
Expand All @@ -763,6 +765,8 @@ def test_reload_success(self):
self.assertEqual(database._encryption_config, encryption_config)
self.assertEqual(database._encryption_info, encryption_info)
self.assertEqual(database._default_leader, default_leader)
self.assertEqual(database._reconciling, True)
self.assertEqual(database._enable_drop_protection, True)

api.get_database_ddl.assert_called_once_with(
database=self.DATABASE_NAME,
Expand Down