Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

feat: add support for updateDatabase in Cloud Spanner #914

Merged
rajatbhatta merged 14 commits into from
May 16, 2023
Merged

feat: add support for updateDatabase in Cloud Spanner #914

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e4163d0
feat: drop database protection
aayushimalik Mar 16, 2023
1d64d5d
feat: drop database protection sample and sample test
aayushimalik Mar 21, 2023
ee653cd
Make sample changes follow client lib spec
aayushimalik Apr 4, 2023
167f68b
Reviewer suggested changes.
aayushimalik Apr 12, 2023
b27fd76
Add test for invalid UpdateDatabaseRequest.
aayushimalik Apr 12, 2023
545cd8c
Update field name `drop_protection_enabled` to `enable_drop_protection`.
aayushimalik Apr 13, 2023
430543c
Formatting fix.
aayushimalik Apr 21, 2023
babd236
Update the `reconciling` field when reloading a database.
aayushimalik May 11, 2023
5420284
Merge remote-tracking branch 'googleapi-python-spanner/main' into dro…
aayushimalik May 12, 2023
a700a02
linting fix
rajatbhatta May 16, 2023
effbfbf
Merge branch 'main' into drop-database-protection
rajatbhatta May 16, 2023
8ad7820
Merge branch 'main' into drop-database-protection
rajatbhatta May 16, 2023
23c2014
Merge branch 'googleapis:main' into drop-database-protection-samples
rajatbhatta May 16, 2023
970cb8a
Merge branch 'drop-database-protection-samples' into drop-database-pr…
rajatbhatta May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test for invalid UpdateDatabaseRequest.
  • Loading branch information
@aayushimalik
aayushimalik committed Apr 12, 2023
commit b27fd76612fd7463a103058769aa1e90876a98e6
11 changes: 10 additions & 1 deletion tests/system/test_database_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,7 @@ def _unit_of_work(transaction, name):
assert len(rows) == 2


def test_update_database(
def test_update_database_success(
not_emulator, shared_database, shared_instance, database_operation_timeout
):
old_protection = shared_database.enable_drop_protection
Expand Down Expand Up @@ -592,3 +592,12 @@ def test_update_database(
# other test cases.
shared_database.enable_drop_protection = old_protection
shared_database.update(["enable_drop_protection"])

def test_update_database_invalid(
not_emulator, shared_database
):
shared_database.enable_drop_protection = True

# Empty `fields` is not supported.
with pytest.raises(exceptions.InvalidArgument):
shared_database.update([])
Comment thread
aayushimalik marked this conversation as resolved.
Outdated